I create most of my custom themes using Blueprint. Something I always go in and do is make the conditional statement format consistent. I prefer curly brakets, and this is actually the preferred Drupal way (http://drupal.org/coding-standards). And contrary to Drupal coding standards, I actually prefer using shorthand PHP to instead of print commands all over the place. Since I do this every time I use this theme, I wanted to share my work with the community in case there were others like me. Attached is a zipped copy of my work. Hope it benefits someone. Thanks!
Sam Oltz

CommentFileSizeAuthor
#2 blueprint-drupal-fixed.zip33.5 KBpianomansam

Comments

designerbrent’s picture

designerbrent commented

Sam: Would you be able to provide either some examples or, even better, a patch?

pianomansam’s picture

pianomansam commented
StatusFileSize
new blueprint-drupal-fixed.zip33.5 KB

I'm sorry, designerbrent. I thought it had attached my file. Let me try again. FYI, my changes are to 6.x-1.5.

designerbrent’s picture

designerbrent commented
Status: Active » Closed (works as designed)

Thanks for uploading your code changes. I'll be looking into changing the control structures to using {}, however in the .tpl.php files my goal has been to make the tpl's readable by the themer. That is why I have opted so far to do the if statements as they are.

As to the print statements, I think I'll continue using the longhand version.

As it is, I'm only making bug fixes to the 1.x tree and any new development is happening on the 2.x branch.

pianomansam’s picture

pianomansam commented

Fair enough, designerbrent. I come to theming as a developer, so I'm used to using and reading {}. Perhaps themers who are more design oriented are not. I'm not sure how Drupal coding standards apply to themes. Either way, I would encourage consistent usage. There are parts of the tpl files that use brackets and parts that do not. Thanks for your time and your effort to provide this theme. Your work has saved me much time.