Splitting some non-critical stuff off from #575294: Add reset.css through drupal_add_css() instead of through the .info file. I'm removing extra linebreaks only here.

CommentFileSizeAuthor
#8 sevenCSScodestyle2.patch14.85 KByoroy
#6 sevenCSScodestyle.patch2.94 KByoroy
Sevencodestyle.patch13.22 KByoroy

Comments

seutje’s picture

seutje commented
Status: Needs review » Reviewed & tested by the community

I don't see any problems with this

aspilicious’s picture

aspilicious commented

Don't add this before the fieldset patch is in!
Else we have to reroll that patch again.

seutje’s picture

seutje commented

well, fieldset patch went in :D
re-test?

dries’s picture

dries commented

Sevencodestyle.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, Sevencodestyle.patch, failed testing.

yoroy’s picture

yoroy commented
Status: Needs work » Needs review
StatusFileSize
new sevenCSScodestyle.patch2.94 KB
yoroy’s picture

yoroy commented
Status: Needs review » Needs work

ignore previous patch, it's incomplete

yoroy’s picture

yoroy commented
Status: Needs work » Needs review
StatusFileSize
new sevenCSScodestyle2.patch14.85 KB
aspilicious’s picture

aspilicious commented

Seriously why do you want to remove white space between code blocks...
It doesn't happen in garland and I never did it before, it makes the css unreadable...
We have to make a css coding style document before we make such changes, cause I'm confused now...

yoroy’s picture

yoroy commented

Indeed, [#302199] says to do that actually. I have no opinion on this and was just splitting out tasks from a convoluted issue (#575294: Add reset.css through drupal_add_css() instead of through the .info file).

yoroy’s picture

yoroy commented

CSS coding standards: http://drupal.org/node/302199 I just don't think they're really agreed upon. Most core css files do not have empty lines between statements.

aspilicious’s picture

aspilicious commented

Selectors
Selectors should be on a single line, with a space after the last selector, followed by an opening brace. A selector should end with a closing brace that is unindented and on a separate line. A blank line should be placed between each block of selectors.

.book-navigation .page-next {
}

.book-navigation .page-previous {
}

Maybe I'm just blind or stupid but I can't see the rule that is saying remove the blank lines...

dries’s picture

dries commented
Status: Needs review » Fixed

Finally! Fewer characters too. Committed! ;)

aspilicious’s picture

aspilicious commented
Status: Fixed » Needs review

We have to change the css coding standards then...
I'm confused... very confused...

Needs review cause I want discussion!

casey’s picture

casey commented
Status: Needs review » Fixed

Lets keep this one fixed. there are already some discussion on css coding standards. Maybe you can drop in there. Else you could open a new issue.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.