module_invoke_all('filefield_paths_process_file', ...) in modules/comment_upload.inc can't be used in PHP 5.3, since some parameters for this hook are required to pass by reference. The standard fix is to call all hooks by hand:

- module_invoke_all('filefield_paths_process_file', $file['new'], $file, $ffp['#settings'][$file['name']], $node, $update);
+ $hook = 'filefield_paths_process_file';
+ foreach (module_implements($hook) as $module) {
+ $function = $module .'_'. $hook;
+ $function($file['new'], $file, $ffp['#settings'][$file['name']], $node, $update);
+ }

CommentFileSizeAuthor
comment_upload.inc_.php53.patch627 bytesmaximpodorov

Comments

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Issue summary: View changes
Status: Active » Closed (won't fix)

No longer supporting Drupal 6 issues for this module.

maximpodorov’s picture

maximpodorov commented

Maybe you can give maintainer rights to someone (e.g. to me) to continue 6.x support for those who use the module actively on D6 sites.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented

Are you putting your hand up?

I've had offers in the past, and have also been burned in the past by some co-maintainers, and as such I need to ensure any co-maintainer will actively look after the module and not break it, which involves understanding exactly how the module works.

If you are putting your hand up, shoot me an email via my D.o. contact form.