Step to reproduce:
1) Open http://example.com/install.php
2) In choose profile step select checkbox Standard (Install with commonly used features pre-configured.)
3) Save and continue button click.

Displayed message

The following error must be resolved before you can continue the installation process:
Error message
Strict warning: Only variables should be passed by reference in install_select_locale() (line 1193 of /www/drupal-7.x-dev/includes/install.core.inc).

PHP 5.2.11 (cli)

CommentFileSizeAuthor
#4 install.core_.inc_.php53.strict.patch583 bytesmacedigital
#2 install.core_.inc_.patch718 bytesgashev

Comments

gashev’s picture

gashev commented

install.core.inc diff:

1193c1193,1194
<           $output = drupal_render(drupal_get_form('install_select_locale_form', $locales, $profilename));
---
>           $_form = drupal_get_form('install_select_locale_form', $locales, $profilename);
>           $output = drupal_render($_form);
gashev’s picture

gashev commented
StatusFileSize
new install.core_.inc_.patch718 bytes
David_Rothstein’s picture

David_Rothstein commented
Status: Active » Needs work

I think these kinds of things are being fixed at #348448: Always report E_STRICT errors, although it's certainly fine to fix it separately here!

However, there appears to be something messed up with the patch format (the patch does not apply)? - and also, variable names shouldn't start with an underscore. Instead of $_form, use something like $form instead.

macedigital’s picture

macedigital commented
StatusFileSize
new install.core_.inc_.php53.strict.patch583 bytes

I also stumbled upon this one during installation of drupal 7.alpha3 and attached a patch just in case (it pretty much boils down to same as in @2).
PHP 5.3 has become a lot more strict in general how references may be used so I'll also take a look at the issues reporting at #348448: Always report E_STRICT errors and will try to chip in if I find more 5.3 related issues.

David_Rothstein’s picture

David_Rothstein commented
Status: Needs work » Needs review

Patch looks good to me - let's put it up for review so it will get tested.

mfb’s picture

mfb
they or he
commented
Status: Needs review » Closed (duplicate)

This is now fixed in #348448: Always report E_STRICT errors

David_Rothstein’s picture

David_Rothstein commented
Status: Closed (duplicate) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.