The buttons provided by this plugin have no icons.

Comments

fizk’s picture

fizk commented

Same here.

aren cambre’s picture

aren cambre commented
Status: Active » Needs work

I don't know how to efficiently address this. The problem is there is a plugin.js that tells CKEditor to add the new buttons. The path to the button must be specified in the .js file.

I'm struggling with how to add the path to the icon in the .js file in a way that is flexible enough to allow the module to be in any of the valid module locations under /sites: /sites/all/modules or many variants of /sites/sitename/modules. I guess I could require the module to only be under /sites/all/modules, but I think that's bad design.

So any thoughts?

mrfree’s picture

mrfree commented

Why don't you simply add a new entry in the "format" select menu instead of using buttons?

aren cambre’s picture

aren cambre commented
Status: Needs work » Postponed (maintainer needs more info)

How is that done?

kylehase’s picture

kylehase commented

That's a good idea. Also, since additional options in the select menu don't clutter the toolbar you could add a lot more language syntax options.

Not everyone enables the format selector though, so a new select box for geshi might be the way to go.

- <default blank>
- Code PHP
- Code Bash
- Code DOS
- Code CSS
...etc

sites/all/libraries/ckeditor/plugins/format/plugin.js is a good template of how it's done.