Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Categorizing this as a bug, since it's a UI problem:
See this forum topic- an example of something that should be simple is way too hard:
The basic problem is users clicking on the filter tips link and then losing the post they composed. Thus, being able to have this link open in a new window is desireable.
existing code:
$extra = l(t('More information about formatting options'), 'filter/tips');
could be changed to make this link themeable, such as:
$extra = theme('filter_tips_more_info');
...
function theme_filter_tips_more_info () {
return l(t('More information about formatting options'), 'filter/tips');
}
Or (alternatively) have this link open in a new window by default, or provide some other way to configure it.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | theme_filter_tips_6.diff.txt | 1 KB | beginner |
| #5 | theme_filter_tips_5.diff | 1009 bytes | pwolanin |
| #1 | theme_filter_tips_1.txt | 5.63 KB | pwolanin |
Comments
Comment #1
pwolanin commentedAttached patch implements change as suggested above, and does a little code cleanup by removing some of the markup from inside t-ified strings. Also removes the unused $extra parameter from function theme_filter_tips.
Comment #2
beginner commentedbookmarking: I'll review this early next week.
Can you just make sure your patch still applies?
Comment #3
beginner commentedoops. Sorry for the delay.
Why did you change the formatting for all the strings? As far as I can see, the text has not changed at all, and it is not relevant to the issue at hand. Doing so also forces the translator to re-translate strings they have already translated. I think the guidelines say that html is allowed in long strings, but if you really think the
<p>should be extracted from the strings, open a separate issue. But the translators will not be happy to have to re-translate all of those strings when the end result is the same.Can you reroll a patch for current HEAD, without any of the string changes (both in filter_help() and in filter_admin_format_form()).
Comment #4
pwolanin commentedhmmm, yes apparently I got carried away with moving the markup ourt of the t() strings. I'll try to split this patch into two.
Comment #5
pwolanin commentedhere's a truly minimal patch to accomplish the goal stated in the title
Comment #6
pwolanin commentedComment #7
beginner commentedok, patch is much simpler this way and ready to go.
attached is the same patch as above, but diffed from the root directory.
Comment #8
drummCommitted to HEAD.
Comment #9
(not verified) commented