Hi,
The Vertical Tabs seems to not work with Event 6.x-2.x-dev, and a 'null' title appears on the event tab. See
http://tc.indymedia.org/admin/node/add/event

If this is some odd module conflict or something I will update. I have tried clearing caches to no avail. Thanks!

CommentFileSizeAuthor
#16 vertical.patch540 bytesyngens
#8 vertical_tab_title.patch579 bytesmd2

Comments

hongpong’s picture

hongpong commented

I have opened a corresponding ticket on Vertical_tabs, sorry I wasn't sure which module to post the conflict to. Thanks!
http://drupal.org/node/728020

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Site is offline, can't confirm the bug.

hongpong’s picture

hongpong commented

Sorry it is back online now. I am trying to get resourceful with the
http://drupal.org/handbook/modules/vertical-tabs
i am trying

$conf['vertical_tabs_forms']['page_node_form'] = array('vertical-tabs-event' => FALSE);
$conf['vertical_tabs_forms']['page_node_form']['vertical-tabs-event'] = array('menu' => FALSE);
$conf['vertical_tabs_forms']['vertical-tabs-event'] = array('menu' => FALSE);
$conf['vertical_tabs_forms']['page_node_form'] = array('event' => FALSE);

I think the first one is the one that should work( or possibly the 4th), however it seems that technically the vertical-tabs-event string is a CLASS and not an ID. (the doc says // Enable vertical tabs but be selective of which fieldsets are included. By default all fieldsets are tabified. To exclude certain fieldsets, use an array with the fieldset ids associated with FALSE values.)
Thanx!

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

The Event module needs to provide a title for its fieldset. That's why its getting a 'Null' for the summary title.

aimutch’s picture

aimutch commented

Dave,

Can you point to where this would be implemented?

Thanks,

Andrew

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Problem is line 2129 of event.module:
$form['event'] = array('#type' => 'fieldset', '#tree' =>TRUE);

The fieldset element needs a #title attribute.

aimutch’s picture

aimutch commented

Thanks! I just found that myself. I'll see if that can get patched up.

md2’s picture

md2 commented
Status: Active » Needs review
StatusFileSize
new vertical_tab_title.patch579 bytes

Patch attached that fixes the issue.

budda’s picture

budda
Primary language English
Location Cheshire
commented
Title: Vertical Tabs shows null tab for events » Vertical Tabs shows 'null' tab for events

Patch works. Should the title be "Events" though?

hongpong’s picture

hongpong commented

Thanks, DaveReid & md2, this patch solved the problem. I set 'Start-End Dates' instead of "events" for the title, but to each his/her own.

Scyther’s picture

Scyther commented
Status: Needs review » Needs work

Please add this in the next release!

Scyther’s picture

Scyther commented
Status: Needs work » Reviewed & tested by the community
aimutch’s picture

aimutch commented

Any reason that this can't be rolled into the next release? I've had this patch applied on a live site for almost a year without any problems.

yngens’s picture

yngens commented

With today's (July 5, 2011) release of event 6.x-2.x-dev patch in #8 gives:

patching file event.module
Hunk #1 succeeded at 2125 (offset -1 lines).
yngens’s picture

yngens commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new vertical.patch540 bytes

Working patch against the latest dev version of the module.

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Needs review » Fixed

thanks, committed.

Status: Fixed » Closed (fixed)
Issue tags: -vertical tabs, -verticaltabs

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +vertical tabs, +verticaltabs

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.