Coder Tough Love D7 upgrade

subscribe

patch fails against coder_tough_love-6.x-1.x-dev.tar.gz

Does it work against the CVS?

Bump, could maintainer (please please) test against cvs and integrate.

IMHO It would be a waste if not done. Specifically now Drupal 7 is out there and others want to help upgrading modules to a Drupal 7 version, this module will benefit the quality of the module code for a Drupal 7 version.

Specifically since there is already a Coder module working for Drupal 7 http://drupal.org/project/coder

Subscribe!

Subscribe. :)

subscribe

subscribe

Rerolled patch against git.

Super, thanks! Now if only my day would have 48H ;) I could also test.

sub

subscribe

Patch works fine for me, first test-run seems to indicate no problems.

Can we get this committed to a Drupal 7 branch and iterate from there?

works like a charm

Ok, how do we get a release then?

We need to talk to Morbus to get a release.

Alright, I've reviewed this patch. It seems to me the "extra changes" to prevent notices should also be backported to the 6.x branch, no? So it would be better to have those in a separate patch. Also, the change from 0 to unset() doesn't really make sense to me. Instead of all that, wouldn't it be better to use empty() instead? (And FALSE would be more self-documenting than 0, while we're at it.) Regardless, let's put that in a separate issue.

I've confirmed that the changed namespacing of _coder_error() to _coder_review_error() is only present in the 7.x-1.x branch of coder, so that change does belong in this patch.

Here's a patch for a port without the extra stuff.

Ah, there is already a patch for the notices in #340617: PHP notices and undefined variables oh my!.

for tracker readability

For spelling. =P

Fatal errors, this one works...

I've opened the 7.x-1.x branch and created a release node. A development snapshot should be available within 24 hours. Thanks @aspilicious et al!
http://drupal.org/commitlog/commit/7948/e58b9ad56c1453320965c8619c0303c2...

No idea where THAT came from.

I got an error "PHP Fatal error: Call to undefined function _coder_severity_name() in /srv/http/drupal7/sites/all/modules/coder_tough_love/coder_tough_love.module on line 211" using the patch from #19. Replacing _coder_severity_name calls with _coder_review_severity_name calls fixed it. Patch attached.

Ha. Nevermind me then. :)

Looks like you and @aspilicious were testing it at the same time. :)