Steps to reproduce:
1. Enable upload module
2. Go to the create content form
3. Upload file

What is happen:
1. Error occured:

warning: Parameter 2 to taxonomy_access_form_alter() expected to be a reference, value given in C:\xampp\htdocs\drupal\includes\common.inc on line 2829.

Drupal 6.15
Windows
PHP 5.3.1
XAMP 1.7.3

CommentFileSizeAuthor
#15 tac_728406-15.patch585 bytesxjm
#12 tac_728406-11.patch1.58 KBxjm
#3 tac_728406-3.patch879 bytesxjm

Comments

xjm’s picture

xjm
she/her
Primary language English
commented

Odd, D6 expects a plain object when previous versions and D7 both expect references:
http://api.drupal.org/api/function/hook_form_alter/6

4.7 – 5
hook_form_alter($form_id, &$form)
6
hook_form_alter(&$form, $form_state, $form_id)
7
hook_form_alter(&$form, &$form_state, $form_id)

hook_form_FORM_ID_alter() also expects a reference:
http://api.drupal.org/api/function/hook_form_FORM_ID_alter/6

6 – 7
hook_form_FORM_ID_alter(&$form, &$form_state)

We can get around it by using the latter hook instead, which is better practice anyway.

xjm’s picture

xjm
she/her
Primary language English
commented
Assigned: Unassigned » xjm
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new tac_728406-3.patch879 bytes

Patch attached. Needs testing.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs review » Postponed (maintainer needs more info)

jan.koprowski, can you test whether the patch in #3 resolves the issue for you? I don't actually get the error on my system when I follow your steps above, possibly because I'm using PHP 5.2.

jan.koprowski’s picture

jan.koprowski commented

I'm really sorry for late. I use newest Drupal 6 version and Taxonomy Access Control 1.0 and all works grate! Thanks!

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Postponed (maintainer needs more info) » Fixed

So merely upgrading to Drupal 6.16 resolved the issue? Or did you apply the patch in #3?

Marking "fixed" for now. If using the patch was what fixed the issue, please change the status to RTBC instead.

jan.koprowski’s picture

jan.koprowski commented

I only Upgrade Drupal and TAC module - I don't apply patch to code. Thanks :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

jan.koprowski’s picture

jan.koprowski commented
Version: 6.x-1.0 » 6.x-1.2
Status: Closed (fixed) » Needs work

I wrote this start working but because people stop reports errors but this wasn't true.
This patch works perfectly and should be added to current TAC release. It solve reported error.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs work » Postponed (maintainer needs more info)

#9: I still don't understand. If the patch in #3 resolves the issue for you, please mark the issue status "Reviewed and Tested by Community" and I will commit it. ("Needs work" means that there is a problem with the patch.) Thanks!

jan.koprowski’s picture

jan.koprowski commented
Status: Postponed (maintainer needs more info) » Reviewed & tested by the community

I'm sorry. I missed this status. My fault. Done.

xjm’s picture

xjm
she/her
Primary language English
commented
StatusFileSize
new tac_728406-11.patch1.58 KB

Attached patch is a reroll against the current dev build.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Needs review

Setting back to NR until I can test create functionality with the new patch.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs review » Needs work

Hmm, preserve_terms isn't getting called with the patch. Troubleshooting now.

Edit: so it looks like hook_form_FORM_ID_alter() only works for specific node types. I'll just nuke the reference in the hook_form_alter instead.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new tac_728406-15.patch585 bytes

I think this is the tiniest patch I've ever made. One character!

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Latest version works fine.

xjm’s picture

xjm
she/her
Primary language English
commented
Version: 6.x-1.2 » 6.x-1.x-dev

Fix committed to 6.x-1.x-dev:
http://drupal.org/cvs?commit=401462

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.