Closed (fixed)
Project:
Upgrade Status
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
28 Feb 2010 at 22:24 UTC
Updated:
18 Sep 2010 at 18:30 UTC
Jump to comment: Most recent file
Comments
Comment #1
philbar commentedThis appears to be related to "Show snapshot release" in the module administration.
Comment #2
philbar commentedIn
http://updates.drupal.org/release-history, these modules are listed as:<project_status>unsupported</project_status>I think this is the reason for this bug. Perhaps there should be some text to denote that there is a development version, but it is "unsupported".
Comment #3
klonosAny news on this one?
@sun: Daniel, ping?
Comment #4
sunHrm. Well that means there is not even a development release, so it would be wrong to display "In development", wouldn't it?
Comment #5
philbar commentedThere IS a development release. It just has been marked as unsupported. See the attached image for the setting in the "Administer Releases" of a project.
Skinr for Drupal 7.x is a good example of developers marking modules as "unsupported" but are actively developing them.
Comment #6
klonosI confirm what philbar noticed. All such modules seem to simply have versions available, but they are marked as 'unsupported'.
(...edited title to reflect this finding.)
Comment #7
sunStill not sure. If I just port something, then I'd create a new major branch and dev snapshot release. Additionally marking it as unsupported means that the code has known issues, may not even work at all, and people should not use it -- at least that's the current meaning, since Update Status will also bail out + spit some site security errors at you.
Hence, the question whether to display unsupported releases or not is mainly a question of user audience. If it's developers, then we can include unsupported. If it's "end-users", then they probably shouldn't consider unsupporte.
Comment #8
klonosI agree with you Daniel that setting a module release to "unsupported" should be used as you state it should, but still you know how people misuse this setting (developers most of the times set versions as such to avoid 'when-will-it-be-ready' questions).
As for the developers/beta-testers vs. end-users case, you know how most end-users wait till there's a stable version available. The first use Update Status to see when there's something available for testing (in order to help with development) while the second simply wait for the status to get 'green' in order to upgrade their sites. So, as long as 'In development' and 'Unsupported' remain a color other than green, we should be ok with end-users ;)
Comment #9
sunok, so where's the patch? :)
Comment #10
klonos...working on #620714: Denote modules which are in D7 Core right now, lets see if I can do something about this once I'm finished with that one.
Comment #11
philbar commentedWe have a few options to include
UPDATE_STATUS_NOT_SUPPORTEDOption 1: Mark it as "Unsupported"
Option 2: Mark it as "Not ported yet"
Option 3: Mark it as "In development"
For which should I create a patch?
Comment #12
sunShall we try 3) "In development" first, as this issue title suggests?
We definitely need an inline code comment then, explaining the situation. More or less a shortened up-to-the-point summary and combination of comments #7 and #8.
Comment #13
philbar commentedOption 3 it is...
Comment #14
philbar commentedComment #15
philbar commentedComment #16
sun1) Strange indentation.
2) We never use tabs in Drupal. Only two spaces (for one indentation level).
3) All code comments should wrap at 80 chars. And they should form proper sentences, i.e., end in a period.
4) The comment will be outdated when we are checking the upgrade status against D8.
5) "Include modules that have a D7 release but the maintainer has marked it unsupported" can be shortened to "Unsupported releases".
6) The comment does not explain any of the essential details of #7 and #8, i.e., it's not clear why we are treating unsupported stuff as supported. That's what we are actually doing here.
Powered by Dreditor.
Comment #17
philbar commentedTwo lines in the patch...6 points in the comment
Perhaps you should write the fix as you like it.
P.S. Do you know how to set Dreamweaver so it writes 2 spaces instead of tabs?
Comment #18
sunThanks. The point of code reviews and coding standards is to manage expectations and prevent unnecessary additional workload.
Committed.
A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.