Incorrect weight sent to google checkout? 1/2 of correct weight!

In the future, please wrap any code with <code></code> tags. That line of code really looks like this:

$output .= '<item-weight unit="LB" value="'. $product->weight * uc_weight_conversion($product->weight_units, 'lb') .'" />';

...and that code is correct. The unit="LB" is telling the Google server that the weight is being sent in units of pounds. The value sent is the product weight times a conversion factor which changes the product weight units into pounds.

So what you need to check is that your product weight units are set correctly for each product on the product page, and that the weights are entered correctly, and that the products are marked as "shippable" (since their weight won't count if they aren't being shipped).

The unit="LB" is what tells Google the weight is in LB. And in fact, LB is the *only* units that Google supports. That line of code is correct - you can read for yourself at: http://code.google.com/apis/checkout/developer/Google_Checkout_XML_API_T...

So the only thing that could be wrong is $product->weight or $product->weight_units contains a wrong value. Print them out to see what they hold.

There is no patch to review.

Please insert the following code below the line described in #1

$debug_weight = print_r($product->weight,true);
watchdog('debug', $debug_weight, WATCHDOG_DEBUG);
$debug_weight_units = print_r($product->weight_units,true);
watchdog('debug', $debug_weight_units, WATCHDOG_DEBUG);

This will print the results to your logs. Then go to www.example.com/admin/reports/dblog to view the results and post them here.

I have a related problem. Mine does not send weight information to GC at all. I followed Andy Lowe's instructions and had a look at the debug log. To my dismay the debug message field is empty; neither weight nor weight unit is printed. What could be behind this? Please note that I have GC payment option only with shipping quotes set up at GC's back-end only.
Your help would be much appreciated.

I also have the same problem. Google shipping quotes not changing if I change product weight.

Am seeing this on a v6.x-2.4 site too.

The $product object from line 467 of uc_google_checkout.module:

stdClass Object
(
    [cart_id] => 39a92672ff8e486c7614b29d45d57efa
    [nid] => 138
    [qty] => 1
    [changed] => 1290959525
    [data] => Array
        (
            [attributes] => Array
                (
                )
            [shippable] => 1
            [module] => uc_product
        )
    [cart_item_id] => 7890
    [title] => Greenies Petite Senior Treat-Pak
    [vid] => 138
    [cost] => 9.68
    [price] => 15.99
    [weight] => 12
    [module] => uc_product
    [model] => GRE04458
    [order_id] => 28019
    [manufacturer] => 
    [order_product_id] => 3938
)

Have changed the status & category of the ticket to match the issue.

@DamienMcKenna: Can I assume that:

1) "12" is the correct product weight - that is, it's the weight you entered on the node/%/edit page for that product?

2) Your product weight_units is set to Kg ?

I'm guessing that the problem arises because the weight_units key doesn't appear in the dump of your product object - this results in uc_weight_conversion($product->weight_units, 'lb') returning "1", so your product weight doesn't get converted to "LB" as needed by Google Checkout. That would only show up as a problem if your product weight_units was set to something other than pounds.

So the thing to track down is why isn't weight_units set? Can you look at the uc_products table and tell me if there is an entry in the weight_units column for each of your products?

#631120: Weight conversion in uc_google_checkout.module silently fails is a duplicate, but is older than this issue and includes two possible patches.

Thanks for finding that longwave. Yes, this seems to be a duplicate.

Can someone review the proposed patch in http://drupal.org/node/631120#comment-2349968 ?

Patch in #631120 works and has been committed.