Closed (fixed)
Project:
Grammar Parser UI
Version:
7.x-1.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
2 Mar 2010 at 01:20 UTC
Updated:
31 Jul 2012 at 18:32 UTC
Jump to comment: Most recent file
Comments
Comment #1
solotandem commentedLatest backport patch is attached.
Comment #3
solotandem commentedThe patch file is now included in the module. Simply apply it with the usual "patch -p0 < gpui.patch" command.
Comment #4
klonos...how difficult is it to create an already patched version of the module as a separate D6 version? I mean... does the patched 6.x version even succeed to detect new versions through the available updates page? I seriously doubt it, since there is no 6.x branch to check against.
Jim, I am reopening this and feel free to set it to 'postponed' if you either have no time or no interest to do it, but please don't close it. Leave it here as a to-do reminder for anyone interested to maintain a 6.x version.
Comment #5
klonos... besides the update issue I present above as an argument to my proposal, please also consider that drupal is meant to be (or become) as user friendly as possible. Having people manually check for updated versions and re-patch each time is not helping to that end at all.
Comment #6
solotandem commentedAre you accessible in IRC? By what nick? Maybe we could toss this around a bit?
A reason to make a D6 release might be if someone was building a D6 module and needed this module as a dependency. (I am not aware of such. If someone is, please let me know.) As it is, this module may only be of developer interest, in which case running it in D7 seems quite reasonable. The API module uses the grammar parser, but I am not aware its developers or testers rely on this module at all. (If someone knows they rely on this module, let me know.)
I am open to discussing this, but so far have not heard a compelling reason to have a D6 release.
Comment #7
klonosUnfortunately I don't use IRC at all :/
As for the need of this, you are correct. The only reason I came across this module is because it was a dependency to the 7.x Coder's submodule Coder Upgrade. This submodule in turn is nothing else than product of merging the 7.x version of Deadwood with Coder.
I guess you know all this since you are the maintainer of one and a co-maintainer of the other module, but the actual reason I re-opened this issue was because there is no Coder Upgrade submodule in the 6.x version of Coder and I see that the only alternative seems to be unmaintained. I thought that if there was a 6.x version of the Grammar Parser UI, then this would pave the road for a 6.x version of the Coder Upgrade/Deadwood that would be in parallel when it comes to features as in the 7.x version of Coder Upgrade. (now that was quite a paragraph - I hope I've made myself understood).
Comment #8
solotandem commentedYour last post helps to clarify the matter.
Let's clarify the dependency statement. This module, Grammar Parser UI, is not a dependency of Coder nor the Grammar Parser. But this UI module has the Parser as a dependency for obvious reasons.
I believe you are referring to Deadwood as the "only alternative" that "seems to be unmaintained." Is that correct? It only has a 6.x release and is not part of the Coder project. I have thought about rewriting or adding to its routines using the new framework of Coder Upgrade and the Grammar Parser. It could certainly be improved with the new tools. A couple of reasons for not doing so:
- I would have expected modules to be converted to 6.x by now.
- Writing upgrade routines is very time consuming and is not being funded.
What is it that you would like to see happen? If others would like to have a 6.x-2.x release of Deadwood using the Grammar Parser, let me know.
Also, following your line of thought, a 6.x version of the UI module would not be the first step to having a 6.x version of Coder Upgrade. The UI module is really not necessary at all for a Deadwood rewrite to use the Grammar Parser.
I look forward to your reply.
Comment #9
ClearXS commentedJust installed a lot of modules I have to investigate for future use + another module to keep track of not activated modules new updates/releases.
I read about a patch to apply, but already is in the new release. So its applied already automatically then?
"Simply apply it with the usual "patch -p0 < gpui.patch" command."
That's new for me (as I'm new to this module); not sure what to do, but probably need to have a deeper look into the project page and related pages, than my nose long is...
Anyway; I changed all the 7.x in the .info files to 6.x of both grammar_parser and grammar_parser_ui.
Yes; I think a separate 6 release would be use-full; at least to keep track on new releases; the 6 core doesn't accept info about new releases for 7. With the many modules I have, it would be difficult to keep track on new updates for these modules without the automatic drupal info.
I now get the 6.x info, but with the info in grey (instead of green) with (in Spanish) "No se encontraron versiones disponibles"; what means: "no available version were found".
Comment #10
solotandem commentedThanks for the post.
If you want this UI module to run in D6, then you need to apply the patch as indicated above in #3. This works on Linux and Mac; Windows is another story. Search drupal.org for the latter.
Again, what do you use this module for in D6 that would justify a release? (Just to keep track of new releases is not a reason for a D6 release. You can track it in D7.)
Comment #11
ClearXS commentedI'll see... Its a quite advanced module for php programmers what I'm not. So retreiving my mind why I selected these two modules grammar_parser and grammar_parser_ui:
I see that API depends on Grammar Parser: "Requerido por: API (desactivado), Grammar Parser UI (desactivado)"
(sorry in Spanish, but the words almost the same as in English)
I selected API for this possible future reason: "You can set up your own API documentation site by following these instructions."
Far away yet, but the idea is to offer Drupal Independent Media downloads and local sites working together for international news. So I thought maybe it does some technical documentation for the downloads I want to offer in the future.
Then the User Interface must be some bridges too far for me for sure, I realize now.
Comment #12
solotandem commentedComment #13
klonosI still think that to satisfy the 'fixed' status, a 6.x version of the module needs to be released. If there is no time to release a 6.x version, than 'postponed' seems more suitable (I doubt that though, since there is already a working patch available). If there is no will/intention to ever have a 6.x version released, then 'won't fix' is appropriate as status.
...but Jim, since you are the maintainer of the module, it's entirely up to you.
Comment #15
klonosI know this is a closed case here, but if there is no 6.x branch where should we file bugs for the 'patched' 6.x version?
Comment #16
solotandem commentedGood question. Just submit an issue under the 7.x version, but make it clear it is a 6.x issue.
Comment #17
klonos;)
Comment #18
solotandem commentedNot exactly sure why I am doing this, but here is an update to using the various Grammar Parser related projects in a 6.x environment. The simplest way is to use the attached make file (remove the txt extension):
drush make --no-core gpui-6x.makeThis make file will:
- download parser, parser library, parser ui, and libraries projects
- apply the gpui.patch to this project, converting it to a 6.x project.
- apply a patch to Libraries 6.x-1.x converting it to a "6.x-2.x" project.
As mentioned in the make file, the only other thing to be done is change the version string to 6.x in the info file for the Grammar Parser Library module. (I could add a patch file to that project to do this.)
Comment #19
klonos...or to actually make a 6.x branch. I know, I know... we've been through that ;)
...besides, I doubt anyone is using this on 6.x. I mean, there's only 4 followers on this issue and I'm sure there'd be more nagging if there was need for it.
Comment #20
cluke009 commentedYou linked the patch to the hmtl page not the plain text. Ftfy.
This will make cleanly now.