Hi,

i created a patch to provide a theme function for block output. allthough i optimized the query's and fixed an unused variable (i think this was copied from counter module).

please review

regads pebosi

CommentFileSizeAuthor
visitors-theme.patch5.26 KBpebosi

Comments

dawehner’s picture

dawehner
Primary language German
commented 
+++ visitors.module	2 Mar 2010 14:34:46 -0000
@@ -292,91 +303,46 @@ function visitors_block($op = 'list', $d
+    $list_items[] = t('Total Visitors: %visitors', array('%visitors' => db_result(db_query("SELECT COUNT(*) FROM {visitors}"))));

This variables shouldn't be generated in the theme function. For me the vars should be generated first and then be used as arguments for the theme function.

Powered by Dreditor.

gashev’s picture

gashev commented
Status: Needs review » Fixed

Fixed to 6.x-0.28.

Thank you.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 5962324 on 7.x-1.x, master, 8.x-1.x, 7.x-1.x-browscap, 7.x-2.x, 7.x-2.x-browscap-separate-table by gashev: 
    bug reports #730248: Provide theme function for block output.

  • Commit 5962324 on 7.x-1.x, master, 8.x-1.x, 7.x-1.x-browscap, 7.x-2.x, 7.x-2.x-browscap-separate-table, 8.x-2.x by gashev: 
    bug reports #730248: Provide theme function for block output.