Thank you again, this is a useful module until webform will provide this functionality without the "pagebreak" limitations.

I think we might have a problem when going back and forward between the different pages of a form, that means that if you go back one page and then you go further you will see that the value of an option list used to hide/show the next one is respected if you changed it but the next elements won't behave as they were supposed to do basing on the hide/show settings.

I think i need to make you an example to make it clear:
suppose we have two elements A (select with two options yes or not with a default Not) and B (textfield) and then a pagebreak and a new page with other form elements.
we chose to show B when the A selected option is Yes.
So, we select Yes and the B elements is correctly shown.
Now, we move on to the next page, but we realize we were wrong and we want to come back, now we see the Yes option selected the way we left that before but the B elements is hidden and we have to deselect Yes and select it again to make the B element appear.

I hope this makes sense to you,
thanks
Da.

CommentFileSizeAuthor
#4 webform_conditional.tgz1.42 KBbidji

Comments

tedbow’s picture

Alright thanks for the detailed description. I think basically I need to run the show/hide events for each element when the page loads.

bidji’s picture

You're right tedbow, just have to run the show/hide events.
I've fixed that easily on my site.
I would post that fix but I see in other issues that you'll wait for a merge with webform.
Are you sure that's really a good idea ?
I understand that merge could be difficult if the module is not stopped, at least temporarly.
But do a merge with known issues which can be fixed easily...

Maybe I should post a patch which merges the other fixes, but I don't want to do that if it's useless.

Could you please answer me ?

Thanks in advance, and don't misunderstand me : you've done a great job with this module !

Marat’s picture

@bidji, I am sorry for the intrusion. In fact I am using this module in a production environment, so if you have a patch please let us share it.

Regarding to merging this module with Webform, I don't think this can be done, at least in the near future. You may have red this comment http://drupal.org/node/732114#comment-2673616

bidji’s picture

StatusFileSize
new1.42 KB

Hi Marat,

Sorry but I can't post a patch today (maybe this week, not sure), I mean a CVS patch. I attached the webform_conditional.js (in a tar.gz) that I use, you can use it or modify it for your needs.

I also used the fix given in this http://drupal.org/node/749702

Tell me if you need some help.

Marat’s picture

@bidji, thank you very much for your post, it's so brilliant! I applied it to my web with the fix you mentioned.

tedbow’s picture

Status: Active » Needs review

Just did a major update to this module. Please test and report back here whether it is fixed or not. Thanks!

tedbow’s picture

Status: Needs review » Closed (fixed)

The module should now work on multiple page forms.