This is not a very important issue. Patch adds encoding, dtd and fixes noscript containing an input element.

CommentFileSizeAuthor
#4 do-invalid-markup-730598-3.patch1.76 KBdirtabulous
#3 do-invalid-markup-730598-2.patch1.53 KBdirtabulous
do-invalid-markup.patch1.42 KBheine

Comments

aspilicious’s picture

aspilicious commented
Status: Active » Needs review

Can use a review

dries’s picture

dries commented 
+++ modules/openid/openid.inc
@@ -79,7 +79,12 @@ function openid_redirect_http($url, $message) {
+  global $language;
+  $output = '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">';
+  $output .= '<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="' . $language->language . '" lang="' . $language->language . '">';
+  $output .= '<head>';
+  $output .= "<meta http-equiv=\"Content-Type\" content=\"text/html; charset=utf-8\" />\n";
+  $output .= '<title>' . t('OpenID redirect') . "</title></head>\n<body>";

This could use better formatting, IMO. Like, why do we add </head> and <body> on the same line as <title>?

dirtabulous’s picture

dirtabulous commented
StatusFileSize
new do-invalid-markup-730598-2.patch1.53 KB

Patch fix appears correct, but is outdated. Rerolled patch and reformatted per Dries comments. All tags on new line.

dirtabulous’s picture

dirtabulous commented
StatusFileSize
new do-invalid-markup-730598-3.patch1.76 KB

Left out a line. Patch updated.

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
commented
Status: Needs review » Reviewed & tested by the community

Applied the patch and it passed all of the tests.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Formatting was Dries's only complaint, and it looks better now.

Ergo, Committed to HEAD! Welcome to the core team, dirtabulous! :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.