In the features updating code in update_api_features_revert() you invoke all features_revert functions that are necessary by running:
$result = module_invoke($component, 'features_revert', $module);
If the return value is TRUE then all is good. However in features.content.inc...
function content_features_revert($module) {
content_features_rebuild($module);
}
There's no return value.
So one of two things...
1. either features module needs to change so that there's always a return value
2. change update_api so that it only fails on a FALSE return value, not null
The attached patch fixes it for #2. But I think #1 would probably be cleaner and more consistent within features.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 730684-update_api-features-revert.patch | 1.04 KB | mrfelton |
| #1 | 730684-update_api-features-revert.patch | 1.09 KB | mrfelton |
| update_api_features_revert.patch | 735 bytes | hadsie |
Comments
Comment #1
mrfelton commentedWish I'd checked the issue queue first. I just wrote a patch to fix this up too, but I also updated the feature revert fuction a little to work more similar to how it does in the latest features code.
Comment #2
mrfelton commentedOops, wrong version of the patch. This one is better (no need to set the semaphore).
Comment #3
q0rban commentedGood catch! Committed: http://drupal.org/cvs?commit=337634