chdir() call leads to fatal error because files can't be included anymore. [#730738]

I'm trying out versioncontrol_git and I'm getting the following error when trying to fetch data from a repository:

Fatal error: require_once() [function.require]: Failed opening required './profiles/openatrium/modules/contrib/ctools/includes/plugins.inc' (include_path='.:/usr/share/php:/usr/share/pear') in /profiles/openatrium/modules/contrib/ctools/ctools.module on line 109

This is due to a chdir() call:

 */
function _versioncontrol_git_log_update_repository(&$repository) {
  $root = escapeshellcmd($repository->root);
  $chdir_ok = @chdir($root); // Set working directory to root.
  if ($chdir_ok === FALSE) {
    return FALSE;
  }

I was able to work around this by setting the include path and removing the './' from the ctools include, but there has to be a better way... :)

Comment	File	Size	Author
#7	versioncontrol_git-no_chdir-730738-7.patch	12.85 KB	mgriego
#4	versioncontrol_git-log_no_chdir-730738-4.patch	6.93 KB	mgriego
#1	versioncontrol_git_log_no_chdir.patch	6.93 KB	mgriego

Comments

Comment #1

mgriego commented 20 March 2010 at 18:08

Status	File	Size
new	versioncontrol_git_log_no_chdir.patch	6.93 KB

I ran into this same problem and have coded the attached patch to fix this. It changes the way the git calls work to use the --git-dir option to the git command instead of doing a chdir() to the repository.

Comment #2

mgriego commented 20 March 2010 at 18:55

Status:

Active

» Needs review

Comment #3

mgriego commented 20 March 2010 at 23:52

Status:

Needs review

» Active

Comment #4

mgriego commented 20 March 2010 at 23:56

Status:

Active

» Needs review

Status	File	Size
new	versioncontrol_git-log_no_chdir-730738-4.patch	6.93 KB

Re-attaching patch with proper status and naming convention.

Comment #5

CorniI commented 21 March 2010 at 13:06

Hi,
thanks for your work, but unfortunately the log parser of vcs_git has undergone a rewrite in #714228: Cleanup and refactor of versioncontrol_git, where this patch doesn't apply anymore. Could you reroll it against the branch oop-refactored in this repository: http://github.com/CorniI/versioncontrol_git/tree/oop-refactored ?

Comment #6

mgriego commented 22 March 2010 at 16:19

Yes, I'll see about rerolling that today.

Comment #7

mgriego commented 22 March 2010 at 22:36

Status	File	Size
new	versioncontrol_git-no_chdir-730738-7.patch	12.85 KB

Here's an updated version of the patch against the oop-refactored branch. This one also includes a small patch to the xgit scripts so that they don't chdir() back into the original working directory until after processing is complete.

Status:	Needs review	» Needs work
Issue tags:		+git phase 2

Most of this was fixed at a sdboyer commit on june, but I still see it at xgit, so changing status accordingly and linking from #484366: Create serverside git hooks to get attention on the work at xgit.