Closed (fixed)
Project:
Pathauto
Version:
6.x-2.x-dev
Component:
Code
Priority:
Major
Category:
Task
Assigned:
Reporter:
Created:
3 Mar 2010 at 05:26 UTC
Updated:
11 Aug 2010 at 23:40 UTC
Jump to comment: Most recent file
There's a lot of funky stuff going on with the hook_user_insert/update hooks. The hook_user_update hook fires are all user operations have been completed, so we shouldn't need to mess with the account object.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 730987-pathauto-user-cleanup.patch | 3.34 KB | dave reid |
| #5 | 730987-pathauto-user-cleanup-D7.patch | 2.89 KB | dave reid |
| #5 | 730987-pathauto-user-cleanup-D6.patch | 5.03 KB | dave reid |
| #3 | 730987-pathauto-user-cleanup-D7.patch | 2.89 KB | dave reid |
| #3 | 730987-pathauto-user-cleanup.patch | 3.64 KB | dave reid |
Comments
Comment #1
dave reidComment #2
dave reidWent through and reviewed user_save() for both D7 and D6. In D7 on both hook_user_insert and hook_user_update() provide a full user object and do not need any adjustment.
For D6, we only need to merge in $account->data and $account->roles on hook_user('insert'). If we change pathauto_user('update') to pathauto_user('after_update') we have a fully loaded user object.
Comment #3
dave reidComment #5
dave reidErg, failed patch was a D6 patch.
Comment #6
dave reid#5: 730987-pathauto-user-cleanup-D7.patch queued for re-testing.
Comment #7
dave reidCommitted to CVS for D7: http://drupal.org/cvs?commit=399668
Re-attaching D6 patch for testing.
Comment #8
dave reidCommitted to CVS for 6.x-2.x:
http://drupal.org/cvs?commit=399684