Hi maintainer of UR,

When a user currently logs into their account and the user has 3 pending requests, they get the messages printed in $messages.
But instead of one notice of pending requests they get one message for each request they have. Is this correct? As per design?

•You have a pending request. Please view your pending relationship requests to approve them.
•You have a pending request. Please view your pending relationship requests to approve them.
•You have a pending request. Please view your pending relationship requests to approve them.

If the user was to have 10+ pending requests, I think it may be kind of scary to see a whole page of the above message upon login.
Is there a better solution to this? Instead of "You have a pending request.." have it say "You have pending requests.."?

rb

Comments

Bilmar’s picture

Bilmar commented

subscribing - I'm currently extensively testing UR to implement the features on my website (awesome module!)
I confirmed that the "You have a pending request..." shows for each pending request the user has received.

I agree that showing the message for each pending request may not be the best..especially for the end user experience.

@alex.k - may this be looked into?

Privatemsg module does the below to notify "You have 1 unread message" if only one message OR "You have x unread messages" when many messages.

if (variable_get('privatemsg_display_loginmessage', TRUE) && privatemsg_user_access()) {
        $count = privatemsg_unread_count();
        if ($count) {
          drupal_set_message(t('You have <a href="@messages">%unread</a>.', array('@messages' => url('messages'), '%unread' => format_plural($count, '1 unread message', '@count unread messages'))));
        }
      }
robby.smith’s picture

robby.smith commented
Title: pending request message shown for each request » plural form for "You have a pending request"

It would be awesome if UR could have the plural form for when there are multiple pending relationships:
"You have pending requests. Please view your pending relationships requests to approve them."
I changed the issue title to better fit the request.

Dear Maintainers of UR: Would this be something that can be considered? It would be a great ++ to user experience.

Thank you!

Melot’s picture

Melot commented

Subscribing

YK85’s picture

YK85 commented

subscribing

rburgundy’s picture

rburgundy commented

kindly bumping

If the site has users receiving many requests in a day, users are currently bombarded with MANY 'you have a pending request' informational messages upon logging in that take up most the screen. I hope this can be changed to ONE 'you have pending requests' informational message when the user has received many.

Is there anyone that could possibly look into a patch to improve this aspect of UR?

Current privatemsg style allows a message in a block for 0 new messages, 1 new message, x new messages.

function theme_privatemsg_new_block($count) {
  if ($count == 0) {
    $text = t('Click here to go to your messages.');
  }
  else {
    $text = format_plural($count, 'You have a new message, click here to read it',
                        'You have @count new messages, click here to read them',
                        array('@count' => $count));
    }

  return l($text, 'messages', array('attributes' => array('id' => 'privatemsg-new-link')));
}

Regards

MAds’s picture

MAds commented

subcribe

chuckbar77’s picture

chuckbar77 commented

Going through the issue queue for a 2011 wishlist =)
Subscribing.

mrf’s picture

mrf commented
Category: support » feature

Moving this over to a feature request, no way to do this currently without modifying the module.

mrf’s picture

mrf commented
Status: Active » Postponed

I am postponing any 6.x feature requests that don't have a current applicable patch to help sort the large list of open features.

Please feel free to set to 'needs review' once a patch is included.