There seems to be a minor typo at file formfilter_ui.module, line 49, HEAD revision, best described by the following diff:

-$form = node_form($form_state, $form);
+$form = node_form($form_state, $node);

I don't know what consequences it has in a runtime, just reporting for the sake of completeness.

CommentFileSizeAuthor
#3 formfilter_ui.patch2.6 KBpillarsdotnet
#1 formfilter_ui.patch1.99 KBpillarsdotnet

Comments

pillarsdotnet’s picture

pillarsdotnet commented
Status: Active » Needs review
StatusFileSize
new formfilter_ui.patch1.99 KB

Patch.

Also corrects these PHP warnings:

  • notice: Undefined index: formfilter_id in sites/all/modules/formfilter/formfilter_ui/formfilter_ui.module on line 92.
  • notice: Undefined index: #suffix in sites/all/modules/formfilter/formfilter_ui/formfilter_ui.module on line 102.
  • notice: Undefined index: formfilter_id in sites/all/modules/formfilter/formfilter_ui/formfilter_ui.module on line 115.
pillarsdotnet’s picture

pillarsdotnet commented
Title: Typo at formfilter_ui.module:49 » Correct node_form() usage in formfilter_ui_node_form() function at formfilter_ui.module line 49, and other PHP warnings
pillarsdotnet’s picture

pillarsdotnet commented
StatusFileSize
new formfilter_ui.patch2.6 KB

More corrections.

pbuyle’s picture

pbuyle commented

#1100240: formfilter_ui.module PHP E^ALL Compliance duplicates this issue.

pianomansam’s picture

pianomansam commented

@pillarsdotnet, thanks for the patch. I'll attempt it myself and see how it goes. If it goes smoothly and we hear from a few others, I can get it committed. Thanks!

pianomansam’s picture

pianomansam commented
Status: Needs review » Reviewed & tested by the community

Patch continues to appear to be working. Marking as RTBC.