The current approach is quite confusing, it was non-obvious (to me, anyway!) from looking at settings.php or reading most of the install related provision code where the credentials are supposed to come from. I spent a while chasing a red herring thinking that they were supposed to come from the template process, or perhaps that the site.php/drushrc.php file was supposed to be added as an include at some point before someone on IRC pointed out that provision adds them to the running environment in the vhost definition. I was trying to use the provision install command independently, so this was not apparent.

Could we add a comment to the settings.php template (and perhaps to the provision_prepare_environment function) explaining this setup?

Comments

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Fixed

Fair enough! Committed vigorous explanations in both settings.php and provision_prepare_environment() to HEAD.

Feel free to patch it if you feel it isn't sufficient.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit ae53eab on debian, dev-dns, dev-envobject, dev-koumbit, dev-log_directory, dev-migrate_aliases, dev-multiserver-install, dev-newhooks, dev-nginx, dev-ports, dev-purgebackup, dev-restore, dev-services, dev-simplerinstaller, dev-site_rename, dev-ssl, dev_server_verify, prod-koumbit, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x by mig5: 
    #731816 - provide comments explaining why and how site db credentials...