Compact forms broken on preview/error

When you say "a version loads without compact forms," do you mean the page loads with the user's last entered text stuck behind the compact form label, and clicking the compact label does not make it fade out as its supposed to?

I'd also like to know more about this. The code/patch looks valid.

nice patch! I so needed this!

I received the following when patching (and mind you, I know very little when it comes to command line anything)...

-bash-3.2$ patch < compact_forms_pre_render.patch
patching file compact_forms.module
Hunk #1 succeeded at 42 with fuzz 1.
Hunk #2 FAILED at 69.
Hunk #3 succeeded at 93 (offset 12 lines).
1 out of 3 hunks FAILED -- saving rejects to file compact_forms.module.rej

Although it seems to work wonderfully.

Thanks again,
Nick

zywiec: the OP is saying that when a form submission fails (ie. when a required field is not filled out) compact forms no longer takes effect. See attached image for example. After a failed attempt, the labels appear spaced wonkily, and they no longer fade in/out on focus/blur. This patch resolves the issue at hand.

This patch works on the 7.x version of the module but throws a notice:

Notice: Undefined variable: form_id in compact_forms_pre_render() (line 78 of sites/all/modules/compact_forms/compact_forms.module).

Any chance of updating for 7.x and commiting? As it is compact forms is unusable.

Absolutely agree with #7!

Thanks for reporting, reviewing, and testing! Committed attached patch to 7.x-1.x.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

The proper fix for D7 would be to use #attached instead, but I don't have time to work on that right now, and this quick stop-gap fix is valid, too (although less performant).

For D7:
- moving code back to form_alter
- using #attached rather than _compact_forms_include_js in prerender
- using hook_element_info_alter() to process the elements

Using the compact_forms 7.x-1.0 I am facing the same problem.

Looking to different scripts I didn't find the one for my version.

So here is the solution working for me :

In the compact_forms_form_alter function, replace the lines

    // Load our page requisites and JavaScript settings.
    if (!isset($loaded)) {
      _compact_forms_include_js($css_ids);
      $loaded = TRUE;
    }

by the lines

    // Load our page requisites and JavaScript settings.
    if (!isset($loaded)) {
      _compact_forms_include_js($css_ids, $form);
      $loaded = TRUE;
    }

Then replace the _compact_forms_include_js function by

/**
 * Include JavaScript and CSS and attach behaviors to all selected forms.
 *
 * @param $css_ids
 *   An array containing CSS form ids.
 */
function _compact_forms_include_js($css_ids, &$form) {
  $path = drupal_get_path('module', 'compact_forms');
  $form['#attached']['js'][] = $path . '/compact_forms.js';
  $form['#attached']['css'][] = $path . '/compact_forms.css';

  $settings = array(
    'compactForms' => array(
      'forms' => $css_ids,
      'stars' => (int) variable_get('compact_forms_stars', 2),
    ),
  );
  $form['#attached']['js'][] = array(
    'type' => 'setting',
    'data' => $settings,
  );
}

Stumbled about the same.
For me I had to add another form id in compact forms configuration
On failure submit form id switched from article-node-form to article-node-form--2