Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.First, I really like this module, so thank you for writing it.
But I noticed that the frontpage link was not being set correctly.
It said ./ was the link. I am not sure it this is an old 4.6 artifact, but i have submitted a patch so that the site_frontpage variable is used to set this link. A small thing, just trying to be helpful.
NOTE: If the RSS feed are turned on, and the frontpage is directed away from node/ then the RSS feed and the link will not match. I didn't really know how to get around that.
-Greg
| Comment | File | Size | Author |
|---|---|---|---|
| site_map.module.patch | 771 bytes | Gman |
Comments
Comment #1
frjo commentedThanks for the patch! I have just committed a new version of the module to cvs that should fix your problem but in a slightly different way than in you patch. Please report back if it works or not.
It will take a few hours for the *.tar.gz to be rebuilt but you can download directly from cvs.
http://cvs.drupal.org/viewcvs/*checkout*/drupal/contributions/modules/si...
Comment #2
Gman commentedYou definitely fixed the frontpage issue, and I like how you added a paragraph break so that the description has some space after it.
But, I see two issues.
1) If no books are choose to be displayed, the general 'Books' heading and description are still displayed.
2) More oddly, if no taxonomy choices are picked, for some reason it always checks off one of them. In essence, it forces me to pick at least one vocabulary. Why does it do that.
Just try unchecking all books and all vocabularies and you will see what I mean.
3) As a small feature request would be to add the depth option to the books, like it is in the taxomony. I like the abiltiy to toggle the book depth on/off, but to be able to determine the depth would be perfect.
Maybe this should all go into a new issue.
Anyway, that for the sweet module. -Greg
Comment #3
frjo commentedThanks for testing the new versions and helping improving this module! A new cvs version is available, same link as above.
1) I believe I have fixed this now.
2) I think this is a shortcoming of the Forms API (that sounds better than that my code is bad ;-). I have set the settings to selects now and that seems to have solved the problem. Less user friendly I believe but it works.
3) That would be nice but it not as easy as it is with taxonomy that has this feature built in. I put it on my ToDo list but don't hold your breath as they say.
Comment #4
frjo commentedComment #5
(not verified) commented