I wrote a little patch that allows to translate the out of stock message. This makes it a "multilingual variable", so you can set it for each language visiting the administration page with each language you activated in your site.

This patch does 3 simple things:

  1. define an hook_init() function that adds 'uc_out_of_stock_text' to $conf['i18n_variables'] array
  2. put in the javascript variable Drupal.settings.uc_out_of_stock.query_path the result of url('uc_out_of_stock/query'), so Drupal can add the prefix for the current language.
  3. use this path (instead of Drupal.settings.basePath+'uc_out_of_stock/query') to get the localized "out of stock" message

    4. It works for me with Out of stock Notification 6.x-1.4

CommentFileSizeAuthor
#4 uc_out_of_stock-multilingual-2-unified.patch2.19 KBfabio84
#1 uc_out_of_stock-multilingual-2.patch2.84 KBfabio84
uc_out_of_stock-multilingual.patch2.15 KBfabio84

Comments

fabio84’s picture

fabio84
Primary language Italian
Location Faenza, Italy
commented
StatusFileSize
new uc_out_of_stock-multilingual-2.patch2.84 KB

I have spoken too early...

If in the page there are more than one "add to cart" form, Drupal.settings.uc_out_of_stock.query_path is setted more than once, and it becomes an array (an effect of array_merge_recursive() used to glue the parts in Drupal.settings), making the throbbler spin forever.

So I defined a static variable in order to set this variable (and add javascript/css) only once.

Now it works better for me.

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented

Quick review/comments, haven't tested.

* The use of i18n_variables in the init is something standard. I am aware that this should be set on the settings.php file, although I can't think why it cannot be set on the init().

* Is your patch standard unified format? It looks odd from what I am used to see (not sure what the ! stands for in the diff format).

Static var is probably not needed, I guess you can add the setting on the init() hook as well, and leave the addition of the css and js where they are now, that w/o the static var.

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
Status: Needs review » Needs work
fabio84’s picture

fabio84
Primary language Italian
Location Faenza, Italy
commented
StatusFileSize
new uc_out_of_stock-multilingual-2-unified.patch2.19 KB

I found out that also in the "core" ubercart modules multilingual variables are defined in hook_init in this way.

I used Eclipse to edit the source and generate the patch. I chose the format "context", but probably I had to chose "unified", sorry... this should be better.

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented

can you please not use the static variable and try what I mentioned on #2?

fabio84’s picture

fabio84
Primary language Italian
Location Faenza, Italy
commented

I had to add the static variable in the second patch because in catalog pages uc_out_of_stock_form_alter is called more than once, so it ensures that Drupal.settings.uc_out_of_stock.query_path is defined only once (otherwise it becomes an array, as I said in #1).

So while I fixed this, I ensured also that the javascript and the css are requested only once. (it doesn't cause problems, but it may improve performance of milliseconds... I'm obsessed with this kind of useless optimizations)

I think is better to define this value only before the inclusion of the javascript, because it's useless if the javascript is not included.

Anyway, this patch is working for me and I'm already using it on a live site, and I'm happy with it.

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
Assigned: Unassigned » hanoii

I appreciate your help with this and this will probably be committed soon. I was asking you to rework that bit only because I feel it's better and cleaner. A setting in the Drupal JS object, even if it's not used, won't really bother at all and I rather use static variables to control one-time execution code only if really necessary as, in my personal opinion, not having it adds readability.

It's not a big deal anyway and It's fine that you are happy with it. I was just mentioning this small tweak only if you were interested in doing it so it can goes directly into the code.

I'll review it soon and fix it.
Thanks again,
a.=

blecheimer’s picture

blecheimer commented

thanks for the patch - it is working for me...that is what I needed ;-)

Romejoe’s picture

Romejoe commented
Status: Needs work » Needs review
hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
Status: Needs review » Fixed

Had to re-roll it to cope with recent changes,,but thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.