Refactor submit handler to process nodes all at once (rather than per row) [#732844]

Currently, the admin form submit handler updates nodes affected by permissions changes on a per-row basis. This adds a lot of unneeded overhead to admin form submissions, because the same nodes may be affected by multiple terms or vocabularies. It would be better to collect a list of affected node ids and then run _taxonomy_access_node_access_update() only once after all other processing has taken place.

Comment	File	Size	Author
#5	tac_732844-5.patch	4.41 KB	xjm
#5
#2	tac_732844-2.patch	5.17 KB	xjm
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

xjm

she/her

English

CreditAttribution: xjm commented 11 March 2010 at 17:05

I looked through the code, and _taxonomy_access_node_access_update() is called in the following functions:

taxonomy_access_admin_delete_role()
taxonomy_access_admin_form_submit()
taxonomy_access_grant_update()
taxonomy_access_defaults_update()
hook_taxonomy()

Numbers 3 and 4 are all called only by the submit handler itself (#2), or by other functions that are in turn called by the submit handler. Therefore, this is what I propose:

Modify _taxonomy_access_cache_affected_nodes() to append more affected nodes to an existing list
Replace calls to _taxonomy_access_node_access_update() in 3 and 4 above with _taxonomy_access_cache_affected_nodes().
Place the following just before return in the submit handler for 'add' and 'save all' cases:
```
_taxonomy_access_node_access_update(_taxonomy_access_cache_affected_nodes());
```
Refactor the 'delete' case in the submit handler to use the cache where it currently calls _taxonomy_access_node_access_update() and then call that once with the cache as above.