I have setup a URL re-write in my drupal org, so that URLs are changed when included on a page. This works when the code displaying or using the URL is passing the URL through the Drupal url() or l() functions. It looks like this module is not doing this, so the URL configured cannot be re-written. Can I request that this is changed so that I can re-write the URL ?

Comments

manfer’s picture

manfer commented

Could you try 6.x-3.0-RC3 now available on project page?

I tried with <front> as a curlypage link and it worked.

I was thinking of the implications of this because it is giving someone with no curlypage administer permission the ability to change how a curlypage would work. Anyway it is supposed that a permission to rewrite URLs is assigned to only an administrator that has a lot of control over a site and with more privileges than a curlypage administrator so he can have the ability to change those urls.

Anyway I would think a little more about it.

Any thoughts on this are welcome. And if someone considers it is not a good solution I could just comment the feature (it is only one line of code to provide this feature) and someone needing it could just uncomment that line.

manfer’s picture

manfer commented

I don't know if this was what you were looking for. If it is not please explain a little more what you mean.

Now passing the link parameter through url:

  • If you use an external link on the curlypage nothing changes, you have just to provide an absolute URL.
  • If you want to use special meaning rutes like <front> it will work fine now.
  • If you have an alias configured, example myarticle as an alias of node/33 you can use the alias.

In previous version not passing the link parameter through url, <front> would work too but the url appearing in the browser was awful, and alias was working too though they had to be specified as /alias (in the example above it would be /myarticle with the leading slash needed, now passing it through url the leading slash is not needed).

It looks more correct to pass it through url and as I said in previous message it has been included in 6.x-3.0-RC3.

TimAlsop’s picture

TimAlsop commented

I have now been able to test with 3.0-RC3 and the URL re-write is working as I need it to. In the Curlypage URL configuration I configure http://domain.com/
and my re-write filter changes domain.com to newdomain.com if I am accessing the page from a different domain. This was not possible with previous release, since the Curlypage module was not using the url() or l() functions, so the re-write hook was not being invoked. Thankyou for making this change for me.

manfer’s picture

manfer commented
Status: Active » Fixed

let's mark this as fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.