rgeorgy [rgeorgy]

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.

As there is already another module with the same purpose, why didn't you open a feature request for it? There is also the option to take over that project.
As reported in http://drupal.org/cvs-application/requirements, the proposed module must not duplicate the work done in an already existing project.

Endless page module is already orphaned (http://drupal.org/node/581952) as the maintainer is not replying to issues no more.

In that case you should follow what reported in http://drupal.org/node/251466 (Dealing with abandoned projects).

While Endless Page module utilizes views style plugin, this module utilize the newly introduced *pager* plugin, In order not to override a whole style just for the pager.

It makes more sense to implement a pager plugin than to implement a style plugin.
Thanks for replying to the questions.

I moved #581952: Endless Page seems abandoned to the Drupal.org webmasters' queue to mark the module as abandoned.

I will review the code tomorrow, or the day after.

1. function views_infinite_scroll_theme() {
     $path = drupal_get_path('module', 'views_infinite_scroll');
     require_once "./$path/theme/views_infinite_scroll_theme.inc";
   

   There is no reason to include the file containing the theme function in hook_theme(), which just lists the theme functions implemented by the module; there is a way to say to Drupal which file contains those function, and Drupal will load it automatically.

2. The implementation of hook_init() is empty; it should be removed.
3. The implementation of hooks should have a comment like Implements hook_menu()..

Remember to change status, when you upload new code, or I could not notice you fixed the code. :-)

It's good to go.

Thank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.