Use fallback behavior when editing content prevents prepopulating on the add form [#733020]

When "Use fallback behavior when editing content" is turned on the new node form at node/add/TYPE/NID does not have my node reference field displayed.

I believe this is because of a if on line 396

<?php
  if (isset($referenced_nid) && (empty($field['widget']['edit_fallback']))) {
    $element[0]['nid'] = array(
      '#title' => $field['widget']['label'],
      '#type' => 'nodereference_url',
      '#field_name' => $field_name,
      '#default_value' => $referenced_nid,
    );
  }
?>

I think this is a mistake but I do not know what one is trying to catch here

Comment	File	Size	Author
#3	nodereference_url_fallback2.patch	1.4 KB	quicksketch
#2	733020_nodereferenceurl_fallback.patch	528 bytes	hefox

Comments

Comment #1

batbug2 commented 6 March 2010 at 13:04

Yep, same problem here.

Solved by changing that line #396 to

if (isset($referenced_nid) && (!empty($field['widget']['edit_fallback']))) {

Comment #2

hefox commented 8 March 2010 at 06:48

Status:

Active

» Needs review

Status	File	Size
new	733020_nodereferenceurl_fallback.patch	528 bytes

I believe it's trying to catch the case that the field has not already been set to something (ie a select or autocomplete).

Comment #3

quicksketch

he/him

commented 13 March 2010 at 01:25

Status:

Needs review

» Fixed

Status	File	Size
new	nodereference_url_fallback2.patch	1.4 KB

Thanks hefox for the patch! I hadn't thought about using the $element['#type'] as the check, but it seems like it works really well. The only problem I found was that it did not work well when editing a node that was using the "leave blank" mode (it would delete any existing value). To fix this, I made the "leave blank" option fallback to autocomplete during edits if using the fallback behavior during edit (we're already doing this for the "page not found" mode).