Posted by quicksketch on March 5, 2010 at 3:52am
| Project: | Webform |
| Version: | 7.x-3.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Since we haven't had this issue opened yet, I'll go ahead and start it here. I'm currently working on the Drupal 7 port of Webform, but it's a big, big task. I'll post status updates here as I make progress. So far I've simply branched HEAD for use as the 7.x branch, Drupal 6 3.x is now in the DRUPAL-6--3 branch.
Comments
#1
Committed #730906: Update string concatenation to match Drupal 7 coding standards to help with D6/7 consistency.
#2
Subscribe! Can't believe there wasn't an issue for this already.
It's a big Job alright Nate, depending on how much of the Field API you intend you use.
And there is the thorny issue of how to store the data.
Is there an overall plan.
eg
7.x.3 - Just get it ported and working
7.x.4 - Start using the new APIs in D7?
Will hopefully be able to test.
Alan
#3
Webform will probably never use FieldAPI, considering it's silly storage of data (every field gets it's own table). See #118984: Field API based rewrite of webform module for my thoughts on that.
But generally yeah 3.x is a straight port. We'll probably won't begin on 4.x until Drupal 7 is clearly the dominant version of Drupal and we can discontinue support for Drupal 6.
Here's my initial port, it's actually *almost* working. The following things work so far:
Things specifically NOT working:
But it's a very good start. After the initial learning curve the port is going quickly and I expect we should be able to get the full version working within a week or two.
#4
I've also committed this small round of changes to the Drupal 6 branch, it's just a set of changes for consistency with the Drupal 7 version.
#5
Please note that 'silly storage' is only the default store. There are other ways.
#6
Another round of fixes, including #737834: Files are not deleted from file components which I found while working on the port.
I also found a few bugs in Drupal core which will affect Webform operating properly:
#737792: Use a "title callback" for node/%node instead of drupal_set_title()
#669510: Merge administration theme with hook_admin_paths()
I would not recommend attempting to use Webform in production without these patches, though they are mostly cosmetic problems.
This set of improvements gets the following working:
Things specifically NOT working:
So looking pretty good. Also attached and committed are another round of backports for consistency between versions.
#7
Surprisingly, CSV downloads required hardly any changes at all. I thought it would have been worse considering the stream-wrapper conversion, but it turned out to be rather trivial. This patch gets downloads working and updates our docs to include Drupal 7 database calls instead of using db_query(). Another small set of backports to Drupal 6. Both patches committed.
I'm actually feeling pretty good about our Drupal 7 port. Though we still have the upgrade path to contend with...
#8
For the time being I've removed the 2.x to 3.x upgrade in the Drupal 7 version of the module. If upgrading from Drupal 6 to Drupal 7, you'll need to update to the 3.x version of the module in Drupal 6 first. However considering it's still currently impossible to upgrade a Drupal 6 site to Drupal 7 (core itself doesn't upgrade yet), I don't imagine this will cause much of a fuss.
This gets us to a point where we can make a release. However please note the following core patches may still be needed to work correctly with the Drupal 7 overlay.
#737792: Use a "title callback" for node/%node instead of drupal_set_title()
#669510: Merge administration theme with hook_admin_paths()
#9
Automatically closed -- issue fixed for 2 weeks with no activity.