Closed (fixed)
Project:
Comment driven
Version:
6.x-1.0-unstable4
Component:
Theming
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
5 Mar 2010 at 04:02 UTC
Updated:
25 Mar 2010 at 06:10 UTC
Jump to comment: Most recent file
Comments
Comment #1
arhak commentedan undesirable side-effect
with this patch, instead of "edit-driven:" you'll get "edit-cdriven-" prefixes
if you think that anything else might be better we are opened to suggestions
and you can run your own tests by changing the value of the prefix at the top of
comment_driven.moduledefine('COMMENT_DRIVEN__DISGUISE_PREFIX', 'cdriven-');another valid issue (a "support request" in this case) would be to preserve same ids as the original comment_form (to support custom themes that might address them), but it doesn't looks trivial in the point we do our stuff in favor of node_form, it would require some time and debug to be achieved
Note: this might not be the only issue regarding theming support
this module needs theme support review and any suggestions that might improve it are welcome,
hopefully we'll get them from issue queue before becoming stable
PS: regretfully unstable4 was already sent to a co-maintainer and should be committed soon without this fix
Comment #2
ManyNancy commentedIs there something strange going on with that patch. I can't download it.
But thanks for the fast response!
I'm don't have more thoughts on the particulars of theming at the moment, but I will bring up more issues as I think of them.
Thanks!
Comment #3
arhak commentedweird.. the file size is correct
re-uploading
Comment #4
arhak commenteddoesn't like that filename?!
Comment #5
arhak commentedrenamed
Comment #6
arhak commentedthere we go
#5 is ok
Comment #7
arhak commentedmmm... I checked and the squared brackets are ok, but the number sign (
#) isn't,of course, URL's fragment!
Comment #8
arhak commentedpatch at #5 fixes the "bug" part of this issue
nevertheless, this side-effect was never intended and preserving same ids as the original comment_form brings support to custom themes that might address them
therefore, this new patch includes #5 plus orig id preservation
Comment #9
arhak commented#8 committed to HEAD
Comment #10
arhak commentedBTW, this is present in unstable4 as well
Comment #11
arhak commentedshould no longer apply for unstable5
Comment #12
arhak commentedre-categorizing