The submit buttons have ids like:

#edit-driven:preview

You can't select that in CSS. Please make it a more normal id so it can be selected.

Thanks!

Comments

arhak’s picture

Title: ids in submit button » parents' names should be form_clean_id compliant (i.e. no colon)
Category: support » bug
Status: Active » Needs review
StatusFileSize
new5.31 KB

an undesirable side-effect
with this patch, instead of "edit-driven:" you'll get "edit-cdriven-" prefixes
if you think that anything else might be better we are opened to suggestions
and you can run your own tests by changing the value of the prefix at the top of comment_driven.module
define('COMMENT_DRIVEN__DISGUISE_PREFIX', 'cdriven-');

another valid issue (a "support request" in this case) would be to preserve same ids as the original comment_form (to support custom themes that might address them), but it doesn't looks trivial in the point we do our stuff in favor of node_form, it would require some time and debug to be achieved

Note: this might not be the only issue regarding theming support
this module needs theme support review and any suggestions that might improve it are welcome,
hopefully we'll get them from issue queue before becoming stable

PS: regretfully unstable4 was already sent to a co-maintainer and should be committed soon without this fix

ManyNancy’s picture

Is there something strange going on with that patch. I can't download it.

But thanks for the fast response!

I'm don't have more thoughts on the particulars of theming at the moment, but I will bring up more issues as I think of them.

Thanks!

arhak’s picture

weird.. the file size is correct

re-uploading

arhak’s picture

doesn't like that filename?!

arhak’s picture

renamed

arhak’s picture

there we go

#5 is ok

arhak’s picture

mmm... I checked and the squared brackets are ok, but the number sign (#) isn't,
of course, URL's fragment!

arhak’s picture

patch at #5 fixes the "bug" part of this issue

nevertheless, this side-effect was never intended and preserving same ids as the original comment_form brings support to custom themes that might address them

therefore, this new patch includes #5 plus orig id preservation

arhak’s picture

Status: Needs review » Fixed

#8 committed to HEAD

arhak’s picture

Version: 6.x-1.x-dev » 6.x-1.0-unstable4

BTW, this is present in unstable4 as well

arhak’s picture

should no longer apply for unstable5

arhak’s picture

Component: Code » Theming

re-categorizing

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.