Parameter 1 to theme_location_geocoding_options() expected to be a reference, value given (Make compatible with PHP 5.3) [#733438]

#1

Posted by spacereactor on March 5, 2010 at 8:05am

another error when i click Map Links
warning: Parameter 1 to theme_location_map_link_options() expected to be a reference, value given in /home/mysite/public_html/includes/theme.inc on line 656.

Login or register to post comments

#2

Posted by spacereactor on April 28, 2010 at 9:24am

anyone know how to fix, is this php 5.3 related problem?
warning: Parameter 1 to theme_location_map_link_options() expected to be a reference, value given in /home/mysite/public_html/includes/theme.inc

Login or register to post comments

#3

Posted by hutch on April 28, 2010 at 11:03am

I am not the author of this code and do not know what the intention was, but the code on line 253 in location.admin.inc:
function theme_location_map_link_options(&$form) { should I think be function theme_location_map_link_options($form) {

The same for line 274 function theme_location_geocoding_options(&$form) { needs the "&" removing.

I cannot test this as I do not have php v5.3.x running anywhere.

Please test this and if it gets rid of the error and the theming still works then provide a patch for the maintainer's consideration.

Hope this helps

Login or register to post comments

#4

Posted by spacereactor on April 28, 2010 at 1:48pm

thank, i remove the two "&" and error message doesn't appear anymore. Can the location Maintainer team confirm and add it to the dev.

Login or register to post comments

#5

Posted by kk_alscg on April 28, 2010 at 3:13pm

Title:

warning: Parameter 1 to theme_location_geocoding_options() expected to be a reference, value given in /home/mysite/public_html

» warning: Parameter 1 to theme_field() expected to be a reference, value given in C:\xampp\htdocs\vhosts\default\htdocs\includes\

Hello,

I am encounter the follwoing error when accessing the page.

warning: Parameter 1 to theme_field() expected to be a reference, value given in C:\xampp\htdocs\vhosts\default\htdocs\includes\theme.inc on line 170.

Code for the function theme is as follows..

function theme() {
static $functions;
$args = func_get_args();
$function = array_shift($args);

if (!isset($functions[$function])) {
$functions[$function] = theme_get_function($function);
}
if ($functions[$function]) {
return call_user_func_array($functions[$function], $args);
}
}

I am getting error while returning the value.

Appreciate if somebody can help me with this..

Login or register to post comments

#6

Posted by spacereactor on April 29, 2010 at 3:13am

Title:

warning: Parameter 1 to theme_field() expected to be a reference, value given in C:\xampp\htdocs\vhosts\default\htdocs\includes\

» Make compatible with PHP 5.3

i not sure if this is location problem. where an when this error occur?

warning: Parameter 1 to theme_field() expected to be a reference, value given in C:\xampp\htdocs\vhosts\default\htdocs\includes\theme.inc on line 170.

Login or register to post comments

#7

Posted by YesCT on April 29, 2010 at 8:36am

Title:

Make compatible with PHP 5.3

» Parameter 1 to theme_location_geocoding_options() expected to be a reference, value given (Make compatible with PHP 5.3)

Sometime &$ is needed in the arg list so that whatever is being passed in can be *altered*

... I think ...

lets keep part of the error message in the issue title so others getting this error will find this issue too.

Login or register to post comments

#8

Posted by hutch on April 29, 2010 at 12:33pm

My (somewhat tenuous) understanding of this is that the &$ should be present in the function definition but not in the call.
so

function myfunc(&$thingy) {
  // do something to $thingy
  .....
}

and

$thingy = "something";
myfunc($thingy);
// $thingy has been altered by myfunc()

That is how I have used it and it works, but I don't know if that way generates an error in PHP5.3.x

Login or register to post comments

#9

Posted by YesCT on April 30, 2010 at 5:27am

Yes, I think that is how I have seen it work in my recent looks into APIs....

Login or register to post comments

#10

Posted by Reg on May 11, 2010 at 11:29am

I don't have this issue however I have seen this error in many other places so I might be able to help with some insight. It usually comes from the function "call_user_func_array" being used, often from an "invoke" such as "module_invoke_all". Reason is this:

http://us2.php.net/manual/en/function.call-user-func-array.php
Note: Referenced variables in param_arr are passed to the function by a reference, others are passed by a value. In other words, it does not depend on the function signature whether the parameter is passed by a value or by a reference.

Anyway, if this is not what's happening, sorry, it just looks like it would be. However, if this is the case check your version of Drupal because of one of the version around 6.13'ish the core was updated to be PHP 5.3 compatible and that may be all you need to make it work correctly.

Login or register to post comments

#11

Posted by astro87 on May 28, 2010 at 10:17pm

My errors was:

1. Click on - Administer › Site configuration › Location > Map links

"warning: Parameter 1 to theme_location_map_link_options() expected to be a reference, value given in C:\strony_www\PHP\xampp\htdocs\drupal-6.16\includes\theme.inc on line 656."

2. Administer › Site configuration › Location > Geocoding Options

"warning: Parameter 1 to theme_location_geocoding_options() expected to be a reference, value given in C:\strony_www\PHP\xampp\htdocs\drupal-6.16\includes\theme.inc on line 656."

I removed ampersand & like in #3 and now I don't see any warnings, I think it work.

[EDITED]:

PHP 5.3.1
Drupal 6.16

Login or register to post comments

#12

Posted by sistro on May 27, 2010 at 5:21pm

The #3 works also form me!

I had also theme problems, solved with this workaround, thanks a lot!

Login or register to post comments

#13

Posted by YesCT on May 28, 2010 at 4:04am

Please (if you have found the fix works for you or if you are posting a new review) include what your php version (and drupal version) is. I believe you can find that easily by looking under reports -> status report .

Also someone please create a patch for this suggested fix (in #3).

[edited to fix mis-spellings]

Login or register to post comments

#14

Posted by hutch on May 28, 2010 at 10:43am

Here is a patch on latest CVS, it removes the '&' from the theme functions theme_location_geocoding_options() and theme_location_map_link_options()
I'm pretty sure this will work, I see no reason to pass a $form object to a theme by reference, it's just display munging.

Attachment	Size	Status	Test result	Operations
location.admin_.inc-make-compat-5.3.patch	1.13 KB	Ignored: Check issue status.	None	None

Login or register to post comments

#15

Posted by YesCT on May 31, 2010 at 8:55pm

Status:

active

» needs review

Login or register to post comments

#16

Posted by lobolo on July 13, 2010 at 7:15am

Hi...

#3 worked out for me...was haunted by the same warning message...

thanks...

Login or register to post comments

#17

Posted by hip on August 10, 2010 at 8:12pm

#3 did it for me too.

Login or register to post comments

#18

Posted by YesCT on August 12, 2010 at 6:32am

lobolo and hip, as the fix from #3 is in the patch in #15, please try to apply that patch and review it so it can be committed as a proper fix to the module. :)

Login or register to post comments

#19

Posted by hip on August 13, 2010 at 11:26am

I actually applied the patch and it did the trick.

+1 to become a proper fix ;-)

Login or register to post comments

#20

Posted by pog21 on September 4, 2010 at 7:27pm

Patch in #14 worked for me.

Login or register to post comments

#21

Posted by kriskhaira on October 15, 2010 at 7:01pm

#14 works for me.

Login or register to post comments

#22

Posted by tangent on December 1, 2010 at 3:23pm

Status:

needs review

» reviewed & tested by the community

The solution is good. Let's commit this please.

Login or register to post comments

#23

Posted by bigpepper on December 4, 2010 at 2:46pm

Perfecto. This patch worked great for me. Well done.

Login or register to post comments

#24

Posted by nilu5233 on December 17, 2010 at 1:30am

Version:	6.x-3.x-dev	» 6.x-3.1
Assigned to:	Anonymous	» nilu5233

when i enter the location-> map linking
it shows me this warning
warning: Parameter 1 to theme_location_map_link_options() expected to be a reference, value given in /var/www/edu/includes/theme.inc on line 656.

i find many ways to solve but it still can't remove it

i see the way "I removed ampersand & like in #3 and now I don't see any warnings, "
but i don't understand what should i remove in theme.inc 656
it doesn't have the signal "&" and "#3"

sorry my english is very poor

thank you

Login or register to post comments

#25

Posted by hutch on December 17, 2010 at 11:16pm

in location.admin.inc, line 292: function theme_location_map_link_options(&$form)
try removing the '&'

Login or register to post comments

#26

Posted by nilu5233 on December 20, 2010 at 4:34am

thank you to reply my question
but i remove the "&", the warning is still on the page

so, what i can do it!?

Login or register to post comments

#27

Posted by rooby on January 4, 2011 at 1:28am

Status:

reviewed & tested by the community

» fixed

There is no need to be modifying the $form variable in those theme functions anyway.

I have committed hutch's fix to all branches.
I also did the same for theme_location_latitude_dms() and theme_location_longitude_dms() in the D7 branch.

http://drupal.org/cvs?commit=473646
http://drupal.org/cvs?commit=473642
http://drupal.org/cvs?commit=473654

Login or register to post comments

#28

Posted by rooby on January 5, 2011 at 1:13pm

Marked #685792: warning: Parameter 1 to theme_location_map_link_options() expected to be a reference as dupliucate of this issue.

Login or register to post comments

#29

Posted by System Message on January 19, 2011 at 1:20pm

Status:

fixed

» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Login or register to post comments

#30

Posted by aceinthehole on June 1, 2011 at 9:35pm

Status:

closed (fixed)

» active

I receive, "warning: Parameter 1 to theme_location_map_link_options() expected to be a reference, value given in /var/www/ijec/includes/theme.inc on line 668."

I am using PHP version 5.3.5 and Drupal 6.22

Here is what the error points to:

  if (isset($info['function'])) {
     // The theme call is a function.
   $output = call_user_func_array($info['function'], $args); 
  }
  else {
    // The theme call is a template.
    $variables = array(
      'template_files' => array()
    );
    if (!empty($info['arguments'])) {
      $count = 0;
      foreach ($info['arguments'] as $name => $default) {
        $variables[$name] = isset($args[$count]) ? $args[$count] : $default;
        $count++;
      }
    }

Login or register to post comments

#31

Posted by rooby on June 2, 2011 at 10:49am

Status:

active

» closed (fixed)

@aceinthehole:
This has been fixed in the dev version.
A new release is a bit overdue actually. I will get one out soonish.
Until then though the dev version will stop that error.
There are also a number of other useful fixes in there.

Login or register to post comments

#32

Posted by aceinthehole on June 4, 2011 at 2:13am

Got it -- thanks Rooby!

Login or register to post comments

#33

Posted by Marcus 78 on September 24, 2011 at 7:53am

Still get the warning: Parameter 1 to theme_location_geocoding_options() expected to be a reference, value given in error

By the way. Can this bug explain why im not getting the coordinates in my view even though i manage to get the adress and other location data?

Login or register to post comments

#34

Posted by Fidelix on September 30, 2011 at 8:20pm

Marcus 78, I'm having the same problem.
The exact same warning, and my map center is in the middle of the map, on the ocean.

Login or register to post comments

#35

Posted by lucabarbetti on October 7, 2011 at 7:13pm

I had the same problem of #30 and it has been solved using the 6.x-3.x-dev version as suggested by rooby at #31.
Thanx a lot!

Login or register to post comments

#36

Posted by naveenvalecha on July 20, 2012 at 10:22am

Thanks Rooby for your answer I will move to 6.x-3.x-dev version and it worked fine for me.

Login or register to post comments

Parameter 1 to theme_location_geocoding_options() expected to be a reference, value given (Make compatible with PHP 5.3)

Jump to:

Issue Summary

Comments

#1

#2

#3

#4

#5

#6

#7

#8

#9

#10

#11

#12

#13

#14

#15

#16

#17

#18

#19

#20

#21

#22

#23

#24

#25

#26

#27

#28

#29

#30

#31

#32

#33

#34

#35

#36

Project:	Location
Version:	6.x-3.1
Component:	Code
Category:	bug report
Priority:	normal
Assigned:	nilu5233
Status:	closed (fixed)
Issue tags:	PHP 5.3