Why is it required to choose content types on which Noded Form Arrange has effect? I think it should not be required.

I want module to be enabled but I want temporarily disable it transforming the form.

Comments

chiddicks’s picture

chiddicks commented
Status: Active » Closed (works as designed)

Each content type has a option for enabling Node Form Rearrange because it's not compatible with some other modules, like forum.

maijs’s picture

maijs commented
Status: Closed (works as designed) » Active

chiddicks, thanks for reply but that was not the thing I addressed. The form requires to select at least one content type. I understand that some modules may not be compatible but the choice it there. I dont really understand why I have to select "at least" one content type to be able to submit the settings form.

chiddicks’s picture

chiddicks commented

I'm sorry, I'm still unclear as to what your request is. Which form are you speaking of?

What's the Use Case here? The only one I can think of is preserving weight settings of the fields despite needing to disable the actual form rearrangement?

maijs’s picture

maijs commented

chiddicks, correct, that's a valid use case to me. Let me ask in return, what is the use case of making "Rearrange Content Types:" form (on Node Form Rearrange Settings page) a required one? I set $form['node_form_rearrange_content_types']['#required'] = FALSE in node_form_rearrange_settings() and it does not break the module at all, only brings more choice to the user.

chiddicks’s picture

chiddicks commented

Yes, I see what you mean now. I will make this change in the next revision.

chiddicks’s picture

chiddicks commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

doublejosh’s picture

doublejosh commented

This needs to be placed in the README.txt
The 4 steps do not include this and (I for one think) it's easy to believe the module doesn't work when skipping this step.

Might suggest this be on the node type page under the Workflow section.

chiddicks’s picture

chiddicks commented

Ok, added to the README.txt. It'll be in the dev snapshot, but I'm not going to make a release just to update the README.

doublejosh’s picture

doublejosh commented

Thanks, makes sense.