Download & Extend

Feed icons generated on pages other than views pages.

Project:Views
Version:6.x-2.x-dev
Component:feed displays
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

This is rather odd.

I have a working view which defines a filter and ordering in the defaults. In short, it's a view of "products".
has two pages displays - the first has a modified filter to show "featured" products on the /home page and the other one shows products (at path "products/%") to show products of a particular taxonomy type.

I went to add a feed display attached to the 2nd page display (the one driven by taxonomy) but, to my surprise, saw the feed icons for ALL the taxonomy terms on every page -- including pages unrelated to any touched by this view! E.g. I'm seeing the feed icons display on my contact page!

I made a copy of the site on one of our dev domains: http://dev1.chicagodrupalauthority.com/
Notice how the contact page ( http://dev1.chicagodrupalauthority.com/contact ) displays the feed icons as well.

Not sure where to go w/ this. I will monitor this issue over the next few weeks. I *think* this is a bug; but am completely willing to be put in my place.

Am running fully patched DRUPAL-6 tag of core and DRUPAL-6--2 tag of views.

Comments

#1

Just as a comment, Views can only attach feed icons when it's running a view, so if you have a page without a view that has feed icons, Views cannot be what is putting it there, because it does not know how.

#2

Interesting; but does not apply in my case. The pages to which I'm attaching a view are views-generated pages. I'm attaching a feed display to that page; but am seeing feed icons for all taxonomy terms represented there. I'm also seeing the feed icons on every other page in the system (!) (like the contact page) -- pages that have nothing to do w/ the view on which the feed display is defined.

#3

Just included the updates made over the weekend to Views DRUPAL-6--2 and the problem still exists.

This really is an odd one.

#4

Title:Feeds attached to page are displayed on every page in system» Feed icons generated on pages other than views pages.
Category:bug report» feature request
Status:active» fixed

So I looked again into this one and comment #1 was actually the lead down the right path.

I have a block on the page that executes all my taxonomy views to see if there are any results (because the filter is complex). If there are results, a menu item is generated. Running the view causes the feed icons to display anywhere that block is displayed.

I am using $view->preview($display, $args); to execute the view and then evaluating count($view->result).

The only way I found I could get around it was to set $view->is_attachment = TRUE before calling preview(). This prevents the feed displays from attaching so no feed icons.

Just in case someone happens to stumble across this.

#5

If you're just evaluating results, may I recommend doing $view->pre_execute() and then $view->execute()? This will skip the render phase, which is a good idea if you are just throwing away the text.

#6

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.