Hi!

It would be great to have the possibility to translate titles, descriptions and labels. Using the translation search I have tried with no success to translate these kind of strings defined in the info file. i18 was enabled.

Thanks / Henrik

Comments

jacine’s picture

jacine
she/her
Location New York
commented
Version: 6.x-1.5 » 6.x-2.x-dev
Status: Active » Needs review

Hi Henrik,

I believe that I have fixed this, though it's only been tested in the Drupal 7 version of Skinr. Can you please test it out?

These are the changes for the 6.x-.1.x branch: http://drupalcode.org/viewvc/drupal/contributions/modules/skinr/skinr.mo...

jacine’s picture

jacine
she/her
Location New York
commented
Version: 6.x-2.x-dev » 6.x-1.5

Oops. Didn't mean to change the version.

hs@henrikstrindberg.se’s picture

hs@henrikstrindberg.se commented

Hi Jacine!

I've tested 6.x-1.x-dev (2010-mar-29) and 6.x-2.x-dev (2010-Mar-29).
Translation works fine for titles, descriptions and labels using the translate interface > search. Great!
But no hits when searching for the strings ”Skinr node settings” and "Skinr comment settings". I could still not translate these two.
And when using the jQuery UI Dialog in the 6.x-2.x-dev the strings will remain in the same language - I believe in the default language - when you switch language. (Sorry for mixing versions :-)

hs@henrikstrindberg.se’s picture

hs@henrikstrindberg.se commented

Hi again!

I can see that the t() function has been used: #title' => t($skin['title'])
There is a discussion about rather using tt() than t() here: http://groups.drupal.org/node/15177
I read about it here too: http://drupal.org/node/292634#comment-2475092
Should it be considered?

jacine’s picture

jacine
she/her
Location New York
commented
Version: 6.x-1.5 » 6.x-2.x-dev
Assigned: Unassigned » moonray
Category: feature » bug
Priority: Normal » Minor

I just committed fixes for "Skinr node settings" and "Skinr comment settings." They should be okay now.

tt() is not a core function so I don't know... I defer this one to moonray. :D

I'm also not sure why the strings wouldn't be translated in the Dialog.

jacine’s picture

jacine
she/her
Location New York
commented
Assigned: moonray » Unassigned
ericduran’s picture

ericduran commented
Status: Needs review » Reviewed & tested by the community

Is this still an issue? Jacine seem to have fix the strings that were not translatable. I did a quick pass through the code everything that should be wrapped in t, is.

Regarding the tt function. That's not needed here, that's for user define strings.

jacine’s picture

jacine
she/her
Location New York
commented
Status: Reviewed & tested by the community » Fixed

Thank you Eric! I just needed to know about the tt() function, and whether or not it should be used here.

Status: Fixed » Closed (fixed)
Issue tags: -multilingual

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +multilingual

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.