Hi

I recently coded a new imagecache action that exposes another preset as an action. See http://drupal.org/node/699154. Would you be interested to incorporate this into the imagecache_actions module? I applied for a CVS account and thought about making a separate project out of it, but I guess it better would fit into a set of other custom actions.

CommentFileSizeAuthor
#5 imagecache_apply_preset_action-6.x-1.0-alpha1.tar_.gz6.53 KBcyberwolf

Comments

cyberwolf’s picture

cyberwolf commented
Title: expose an imagecache preset as an imagecache actio » expose an imagecache preset as an imagecache action
dman’s picture

dman commented

Makes sense to fit this into here. We're already doing that with the autorotate addition.
I can see how this could open things up for sensible re-use in some circumstances, save too much repetition.
I think I'd be happy to roll it in. There's probably not much that can go wrong or need maintainence, although you can join in on this project if you are interested, I wouldn't mind having another pair of eyes on stuff here.

cyberwolf’s picture

cyberwolf commented

Thanks dman. Should I simply attach the module here? Or do you prefer a patch file?

dman’s picture

dman commented

it's a stand-alone module, I imagine, just zip it up here

cyberwolf’s picture

cyberwolf commented
StatusFileSize
new imagecache_apply_preset_action-6.x-1.0-alpha1.tar_.gz6.53 KB

Attaching the module here (the same one as previously attached at http://drupal.org/node/699154).

Would be very happy to see this end up in Imagecache Actions soon. :)

cyberwolf’s picture

cyberwolf commented
Status: Active » Needs review
cyberwolf’s picture

cyberwolf commented

Any news on this one?

dman’s picture

dman commented
Version: 6.x-1.x-dev » 6.x-2.x-dev
Status: Needs review » Fixed

Imagecache_subroutine has been folded in to imagecache_customactions.module
Mostly based on this contribution and suggestion, with an amount of renaming and text explanations added.
Makes a lot of sense, thanks

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.