Cufon module disables $closure in preprocess_page function

Hi,

When activating Cufon, every module that outputs anything in $closure will be broken. I noticed the line $vars['closure'] = theme('closure'); in function cufon_preprocess_page(&$vars) which does nothing but break other modules.

If you want to output anything in $vars['closure'] = theme('closure'); please use hook_footer

in cufon.module in line 112.

Yeah what doublethink said, this module is causing the google_analytics module to output the tracking code twice! Eeek! Anyone having strange problems with their $closure region should comment or remove line 112 of cufon.module

I'd patch but it's a pretty simple fix! Here's hoping the maintainer comes out of hibernation soon ;)

yeah, anything that uses $closure (in my case better_messages weren't displaying) - removing the seemingly pointless $vars['closure'] call frees up other modules from accessing $closure again.

Same problem for me. Enabling Cufon and then better_messages are not displayed ;(

Any other fix for this?

I encountered this too. I've attached a patch that uses hook_footer() to replace what was being done in the preprocessor function. this removes the need to rerender theme('closure') which causes duplicate js to be added for any module (inc. google_analytics) that adds js in its hook_footer().

It still rerenders the scripts variable which should not be a problem and may be needed.

i've applied this patch, but how to know if the code work ? before to see result in GA page...and to be sure there is no problem ...

Try installing Better Messages module. Will it work?

ok i've enabled better messages, but i dont know what the plus...and disabled cufon...no need because i use css properties for typos..will see if events and search tracking works

EDIT: no result, events are still empty..i dont know what thinking about that...

I've applied this patch and while it stops Google Analytics code from printing twice, it has stopped Cufon from functioning. I did have success with the patch from this thread: http://drupal.org/node/591838

hi,

same here theme('closure') broken some modules. I have removed the theme function and moved the selectos js to init function. it´s works fine for me.

best regards
Dennis

The google analytics duplication issue happened for us as well. I hope this patch gets into the module soon.
Cheers! Jamie.

The patch from #591838: Makes the Google analytics pagetracker print twice (need to remove the reset of $closure from preprocess_page) is cleaner than the one in #734630-13: Cufon module disables $closure in preprocess_page function, and should be the one applied to this module.

This is absolutely critical to be committed, and a one-liner fix. Can it be committed ASAP, and a new release rolled?

Thanks so much for the module, btw :)

removing the single line

$vars['closure'] = theme('closure');

works fine here.

Go to the other issue instead: #591838: Makes the Google analytics pagetracker print twice (need to remove the reset of $closure from preprocess_page), as per #15 & 16.