The output processing of EditorialReview is done in 3 places, and they're not all the same. Standardize. I suspect that using _filter_htmlcorrector(filter_xss($EditorialReview)) is the correct approach.

CommentFileSizeAuthor
#6 amazon_store.d7_editorial_review_standardization_735464_06.patch3.99 KBrfay
#5 amazon_store.d7_editorial_review_standardization_735464_05.patch2.94 KBrfay
#3 amazon_store.editorial_review_735464_03.patch4.54 KBrfay
#2 amazon_store.editorial_review_standardization_02.patch4.51 KBrfay
#1 amazon_store.editorial_review_standardization.patch2.96 KBrfay

Comments

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Active » Needs review
StatusFileSize
new amazon_store.editorial_review_standardization.patch2.96 KB

Well, this isn't a 100% fix because the sanitization is still done in 3 places, but at least it's done the same. Please try and report. If you have an editorial review or "product description" that doesn't look right, please provide the ASIN of the problem item.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
StatusFileSize
new amazon_store.editorial_review_standardization_02.patch4.51 KB

And this one is a little better. It solves the problem in #1008774: Editorial reviews with different encoding? and may also solve the problem in #752772: Apparel searches on the Amazon API always time out..

In this patch, the magic parameters passed to Amazon are thinned down, and as a result, Amazon passes us better data. Pretty strange.

Testing results will be appreciated.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
StatusFileSize
new amazon_store.editorial_review_735464_03.patch4.54 KB

This one seems to do the job.

I had failed to request the EditorialReview in one search case, and that caused some trouble.

I checked and this does solve #1008774: Editorial reviews with different encoding?

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Version: 6.x-2.x-dev » 7.x-1.x-dev
Status: Needs review » Patch (to be ported)

Committed to DRUPAL-6--2: https://drupal.org/cvs?commit=491210

Now on to D7

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new amazon_store.d7_editorial_review_standardization_735464_05.patch2.94 KB

Here is a D7 version for review.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
StatusFileSize
new amazon_store.d7_editorial_review_standardization_735464_06.patch3.99 KB

#5 didn't solve #1008774: Editorial reviews with different encoding?. I believe this one does.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs review » Fixed

Committed: https://drupal.org/cvs?commit=491372

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.