By pbarnett on

I've been working on a theme that's based on 'Goofy', but using the phptemplate theme engine.

It works fine but, like the goofy theme, it has a lot of white space between vertically-stacked blocks and nodes.

Does anyone know how to fix this? I'm guessing it's in CSS somewhere...

Thanks in advance!

Pete.

⋅ Categories: Drupal 4.7.x

Comments

pbarnett’s picture

pbarnett commented

Finally sussed it out; there are line breaks
between the elements; just needed to do a string replace in page.tpl.php to remove them.

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

I've always liked the look of the Goofy theme but I prefer to use PHPTemplate. Will you be contributing your version back?

Michelle

pbarnett’s picture

pbarnett commented

There's a version posted at http://drupal.org/node/25491 (this page also has a screenshot of my version; I changed all the graphics and some of the code to get the desired effect.
The posted version still has Goofy's problem with the vertical spacing; I fixed it by adding

<?php $content = str_replace("<br />","",$content) ?>
<?php $sidebar_left = str_replace("<br />","",$sidebar_left) ?>
<?php $sidebar_right = str_replace("<br />","",$sidebar_right) ?>

just before the 'head' section.

Let me know if I can be any more help...

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

I didn't know anyone had ported it. The last time I looked into it was ages ago and it didn't look like anyone was doing anything with it.

Thanks,

Michelle

pbarnett’s picture

pbarnett commented

Hi, Michelle.

Goofy is such a nice theme because you can replace the graphics easily, (nobody liked the bright orange :-), because the way it's written, it just builds a table with the graphics of your choice arranged as a border.

Useful.

Goofy seems to be one of the few themes available that uses that technique.

P.

sepeck’s picture

sepeck commented

Most people have switched to using css for positioning of images and elements.

-Steven Peck
---------
Test site, always start with a test site.
Drupal Best Practices Guide -|- Black Mountain

-Steven Peck
---------
Test site, always start with a test site.
Drupal Best Practices Guide

pbarnett’s picture

pbarnett commented

I appreciate that Tables Are Evil :-)

Unfortunately, I started out from BlueMarine...

sepeck’s picture

sepeck commented

merely mentioned the why. :D

-Steven Peck
---------
Test site, always start with a test site.
Drupal Best Practices Guide -|- Black Mountain

-Steven Peck
---------
Test site, always start with a test site.
Drupal Best Practices Guide

pbarnett’s picture

pbarnett commented

Actually, the original theme used tables; it would be an interesting challenge to rewrite it using CSS... and I was going to have an early night :-)

allankayak’s picture

allankayak commented

HI there,
I just found your post about the theme, can you help me find teh file, I only found the .thme version,

I need to creat more regions in the theme template, but I cant work out how to do this in the .theme file?

(newbee at code)

Hope someone can help.

I am basicly looking for a box type theme where I can easily customise the graphics without messing with much code.

Allan

http://www.riverkore.com/h2o

pbarnett’s picture

pbarnett commented

goofy-phptemplate.tar.gz (44.5 KB)

You can add regions using administer>blocks to create, enable, disable and position the blocks.

Pete.

allankayak’s picture

allankayak commented

Great thanks,

So any reason the theme sort of works, but not quite, on the front page the borders work. but on most other pages I get a borderless, but coloured page?

I renamed the theme folder to straight goofy, but no joy.

(Why are the simple things so comlicated?)

Allan

http://www.riverkore.com/h2o

pbarnett’s picture

pbarnett commented

Hi Allan.

There's certainly something strange going on with your site; I visited the front page which looked fine. Then I went to the articles page at http://www.riverkore.com/node/articles, which displayed the front page without the box graphics!

When I clicked on the header to return to the front page, it took me to http://www.riverkore.com/h2o/node which displayed the front page without the box graphics again.

I tried the Events page at http://riverkore.com/h2o/coming-events and the box graphics were fine...

Looks like there's some problem with the url's... possibly 'Clean URL's' related?

Pete.

allankayak’s picture

allankayak commented

Many thanks

Humm, will have a play with some settings, it all worked fine with old Goofy, and I have not seen this in other themes.

I had been working on customizing sands theme, but I really want a bordered theme, so I thought this might be quicker.

Will see what I can find.

Any other ideas, I'm all ears

Allan

http://www.riverkore.com/h2o

allankayak’s picture

allankayak commented

So turned off clean URLs and things seem to be working except one ting.

I am getting this:- when I study it in firfox, as my log shows an image not found
Broken Images - http://www.riverkore.com/h2o/?q=node/articles
http://www.riverkore.com/h2o/?q=node/articles

1. http://www.riverkore.com/h2o/themes/goofy'/images/null.gif
2. http://www.riverkore.com/h2o/themes/goofy'/images/null.gif

I have looked at the code , but I cant find why there is a ' put in the url, which is incorrect and making this problem?

Any ideas

Allan

http://www.riverkore.com/h2o

damaikar’s picture

damaikar commented

Hi Allankayak

Just stumbled across this thread...have not seen Goofy theme before....your site is shaping up well...looks good.

My question is about your Calendar integration. Could you tell me a bit about it please....eg Is it WebCal and which integration module did you use?

Thanks in advance

Cheers

Stephen G

Remember! Wherever you go...there you are!

PS: (And don't worry Forum Police...I will not make a habit of OFF-Topic posts. I could not email via website is all).

allankayak’s picture

allankayak commented

Hey there

Calander is the events module, and views modules.

Its cool, I intend to use it to post slide shows and lectures. With gmap and location modules you can also make it present a google map of the location the event, which I think is pretty cool.

Eventualy the site will have 5 admins (team) and users will be able to register so they can coment etc. But the site if basicly a blog and presentation of our adventures.

Just getting bogged down in the presentation bit right now.

Allan

http://www.riverkore.com/h2o

damaikar’s picture

damaikar commented

Hi Allan,

Thanks buckets for that reply cobba...that is exactly the good information I hoped for. Much appreciated :-D

I'll keep an eye out to see how you go wrestling with the events/location/presentations bit. Interesting challenge :-P

All the best.

Cheers

Stephen G

Remember! Wherever you go...there you are!

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

LOL! There aren't any forum police. There are volunteer site maintainers who try to keep the forum from descending into chaos but we're hardly police. I've never seen off topic comments deleted unless they were spam, made on a thread that explicitly requested to stay on topic, or otherwise harmful. IMO, your comment is just fine.

Michelle (Badge #23570 ;)

--------------------------------------
My site: http://shellmultimedia.com

damaikar’s picture

damaikar commented

Dear Michelle/NOT Forum Police :-)

Thank you for your kind, funny, 'not-really-semi-moderation' and support of my comment....glad you have a sense of humor :-D

Though as a novice 'Drupallier', I have felt a tad intimidated and pensive about posting at times. It seems that some people get some pretty severe 'clobberings' for things like posting in the 'wrong' thread (my interpretation...I could be wrong! :-P )

But like I said...glad you can have a laugh:-)

Cheers

Stephen G

Remember! Wherever you go...there you are!

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

There's a lot of people on this website and a lot of personalities. Sometimes people do take it upon themselves to jump on someone else for what they consider an infraction. I'd like to think it's the exception and not the rule. Please don't be afraid to post on the forums. I'd hate to see people not posting because they're afraid of being flamed.

To the OP: Sorry for completely hijacking your post. I was just bothered by the forum police comment and the thought that people are afraid to post and wanted to clear things up.

Michelle

--------------------------------------
My site: http://shellmultimedia.com