I just tried out the current cvs and there were a few places where the group context was being lost. Meaning, the group block details didn't show up, and also the generic forum links that were showing up would post forum topics that weren't getting put in the group.

So - i've rolled this patch of my mornings work that fixes this in a few places. One part of the strategy is to create a couple of new url_alias entries with every new group so that links to the generic forum pages (e.g. forum/tid and node/add/forum/tid) are now aliases to 'group aware' links (og_forum/tid/gid and node/add/forum/tid/gid). I've had to play with some of the edit[og_groups][] references as well.

Another strategy would be to mangle the links in your theme, but this one seemed more robust and easier to implement.

It also includes a rename of the default forum from 'Generic Discussion' to forum, just because I think it's better.

As I'm posting this I'm seeing the rest of the outstanding issues - I'll see if there are some of those I can contribute to as well.

CommentFileSizeAuthor
#6 og_forum.module_2.patch1.85 KBdarren oh
#5 og_forum.module_1.patch1.29 KBdarren oh
#2 og_forum.module_0.patch5.14 KBdarren oh
og_forum_patch.diff.txt2.9 KBadixon

Comments

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Version: master » 4.7.x-1.x-dev
darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Assigned: Unassigned » darren oh
StatusFileSize
new og_forum.module_0.patch5.14 KB

Here's a proper patch.

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Status: Needs review » Needs work

Doesn't seem to make any difference. I thought maybe it required the path module, but after the path module was installed it still didn't work.

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented

Marked issue 117321 as duplicate of this issue.

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Status: Needs work » Needs review
StatusFileSize
new og_forum.module_1.patch1.29 KB

Here's a patch that works.

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
StatusFileSize
new og_forum.module_2.patch1.85 KB

This patch not only assigns a group to OG Forum postings, it also prevents OG Forum from taking over all the forums, which should fix issue 68108.

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Status: Needs review » Fixed

Fixed in CVS commit 57472.

rconstantine’s picture

rconstantine commented

I'll see whether this can work with my updates to 5.x. A quick look tells me no, since I had other areas which needed context help (especially to get regular forums working), but I'll look closer.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)