It's about time to look at upgrading to Drupal 7. We will be porting the 2.x version of the module, not the current stable 1.x, so part of the upgrade will also mean we need to fix the bugs in 2.x at the same time. Please do not add comments with +1 or "yeah, when will this be done?" to this issue. This issue for for discussion of the work *being done* and submitting patches.

CommentFileSizeAuthor
#15 nice_menus-735848-15.patch6.23 KBvordude
#12 nice_menus-735848-12.patch5.34 KBvordude
#2 nice-menus-d7-2.patch13.56 KBvordude
#1 nice-menus-d7.patch6.56 KBvordude

Comments

vordude’s picture

vordude commented
Status: Active » Needs work
StatusFileSize
new nice-menus-d7.patch6.56 KB

Spent an hour or so hacking at a D7 port.

This is not stable--or even functional--but a start for making some of the basic api changes.

Hook Block was broken out, and a a db_query was modified to the new format.

I made a couple of paramaters in a couple of theme functions = '' so they would stop yelling at me. I haven't touched doing anything with the new theme system.

I also have not touched the new $ doesn't always necessarily mean jquery change yet.

Not sure if this is helpful, but here ya go:

vordude’s picture

vordude commented
StatusFileSize
new nice-menus-d7-2.patch13.56 KB

Yeah, ignore that first patch. :-)

Here's a better crack at it.

Admittedly, the theme functions have been hacked together into functionality. And could use some cleanup, and/or porting to the theme array magic that I understand comes with D7.

This is nearly functional...missing the api changes surrounding theme('menu_item_link', $menu_item['link'])

You'll note the Menu structure is being built minus that handy <a href="node/1"></a> (and accompanying tags and classes).

add1sun’s picture

add1sun commented

Awesome! Thanks for the first crack at it. I'm hoping to get D6 v2 out the door soon and then branch it. Then we can put this work in HEAD and have a place to play in progress.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Subscribing... :)

Jeff Burnz’s picture

Jeff Burnz commented

Sub-scriben also :)

gordon’s picture

gordon commented

subscribe

adiatis’s picture

adiatis
Primary language Dutch
Location Belgium
commented

Drupal 7.0 beta 1 Released ==> Subscribe.

I can't wait to try this great module in 7 and give feedback ;-)

Sergey Naumov’s picture

Sergey Naumov commented

Subscribing =)

uno’s picture

uno commented

Sub

add1sun’s picture

add1sun commented
Version: 6.x-2.x-dev » 7.x-2.x-dev

OK, I've branched the 6.x-2.x version of the code and opened HEAD up for D7. The patch above needs to be rerolled against the current HEAD. I'll commit it once that happens so continued dev on 7 can run against HEAD without getting bogged down in patch hell.

add1sun’s picture

add1sun commented

FYI, I've committed a blind run of the the coder_upgrade changes to HEAD. It is not a working port but at least takes care of some of the basics from which we can build on. Please submit patches to get a working version for D7 based off of what is in HEAD.

vordude’s picture

vordude commented
Status: Needs work » Needs review
StatusFileSize
new nice_menus-735848-12.patch5.34 KB

Here's a functional, yet ugly patch, tested in the core theme, header "down mode" Firefox only.

The menu looks ugly by default, which will need work

But I'd like to know how functionality is working on this one.

scotwith1t’s picture

scotwith1t
Location Birmingham, AL
commented

subscribe

scotwith1t’s picture

scotwith1t
Location Birmingham, AL
commented
Title: Upgrade to Drupal 7 » Drupal 7 port of Nice Menus

i'm sure i'm not the only one with a bunch of generically titled "port to D7" issues in my queue. changing title so's i can tell which module's had activity!

vordude’s picture

vordude commented
StatusFileSize
new nice_menus-735848-15.patch6.23 KB

Small Changes to further the porting process.

Sets the default link color to blue (which used to come with garland, and white just didn't look right)

Also removed the BLOCK_NO_CACHE since it's out of D7

vordude’s picture

vordude commented

I'm going to commit this patch, since I've given it some simple smoke tests.

I'll roll it into an early release, so the barrier of entry to testing is much lower.

Cleanup and bug-fixes will definitely be necessary.

vordude’s picture

vordude commented
Status: Needs review » Fixed

2.0 BETA 1 has been tagged, and is available for download.

Please open separate issues for problems with the D7 version.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.