Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Fixing bug for:
Notice: Undefined index: op in J:\_Webserver\cvs\modules\node\node.module on line 2044
Notice: Undefined index: destination in J:\_Webserver\cvs\modules\node\node.module on line 2047
Notice: Undefined variable: destination in J:\_Webserver\cvs\modules\node\node.module on line 2051
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | node_58.patch | 1.78 KB | keve |
| #1 | node_56.patch | 1.68 KB | keve |
| node_55.patch | 831 bytes | keve |
Comments
Comment #1
keve commentedFixing some more: (when creating new node)
Notice: Undefined property: stdClass::$nid in J:\_Webserver\cvs\modules\node\node.module on line 1605
Notice: Undefined property: stdClass::$vid in J:\_Webserver\cvs\modules\node\node.module on line 1605
Notice: Undefined property: stdClass::$changed in J:\_Webserver\cvs\modules\node\node.module on line 1605
Notice: Undefined property: stdClass::$nid in J:\_Webserver\cvs\modules\node\node.module on line 1656
Comment #2
drummThe second condition in the second hunk simply checks if the node id is not 0; I don't think that is needed.
drupal_goto()'s default value for where $destination is used is NULL. I think the defualt value of $destination should be NULL instead.
Comment #3
keve commentedRerolled to HEAD.
Comment #4
bdragon commentedOut of date HEAD warning fix patch closing -- Since HEAD must be E_ALL
compliant now, I am certain this has been fixed.
Comment #5
drzraf commentedIf you node_validate() a new node:
node_last_changed() will try to fetch "created" from the DB node object but that property does not exists.
Then it will check this against $node->created which may be NULL too (if inserted programmatically).
In the worse case, you can get spurious "The content on this page has either been modified by another user, or you have already submitted modifications..."
Some more checks of variables are probably needed here.
Comment #6
drzraf commented(hum... I was using fake (rand()) nid, so my node->nid existed without being in the DB)