Hello

Thanks for creating this module - its been very useful.

I noticed some issues on a dev site that uses revisions. The way the code is now, if your nid value of a node is different to the vid then you will encounter problems, perhaps with the count being assigned to a different node altogether.

I will be adding a patch here.

CommentFileSizeAuthor
#1 nodereference_count_736846_vid.patch1.83 KBsmoothify

Comments

smoothify’s picture

smoothify commented
StatusFileSize
new nodereference_count_736846_vid.patch1.83 KB

Here is the patch....

gilgabar’s picture

gilgabar commented
Status: Active » Needs review

Thanks. I hadn't had time to handle revisions correctly, so the patch is much appreciated. I'll review as soon as I get a little time. Thanks again.

gilgabar’s picture

gilgabar commented
Status: Needs review » Fixed

Patch looks good. Committed to HEAD and should be available in a dev release shortly.

I'm curious about the optional vid argument on nodereference_count_update_count() added. It doesn't appear to be used. Is there an intended use or is it just there in case it becomes useful? I have no objections to including it. Just curious if you have something in particular in mind.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.