If anonymous checkout is enabled, the descriptive text
<b>Optional.</b> New customers may supply custom account details.<br />We will create these for you if no values are entered.
cannot be translated since the text is retrieved from the variables table.

The attached patch corrects this.

CommentFileSizeAuthor
ubercart_checkout.patch1016 bytesreglogge

Comments

tr’s picture

tr commented
Status: Needs review » Closed (works as designed)

i18n already has a mechanism for translating variable table variables - that's what you should use. That's why this line appears in uc_cart.module:

  $conf['i18n_variables'][] = 'uc_cart_new_account_details';

Besides, your patch is just wrong - you're throwing away the variable but leaving the admin menu that allows you to configure that variable?

laghalt’s picture

laghalt commented

Besides that reglogge´s patch works.

Yes - there is a i18 variable that dosent work. The original bugg might be that that variable is flushed somewhere in the code or somthing like that.

If you cant find that error since you dont have dev-documentation - this is a correkt buggreport.

Thanks for the fix.

mducharme’s picture

mducharme commented
Status: Closed (works as designed) » Needs review

Why was this patch not pushed into a release? $conf['i18n_variables'][] = 'uc_cart_new_account_details'; does not work and other #description fields within ubercart do not use the variable_get at all and use the patch's format:
/modules/ubercart/uc_cart/uc_cart_checkout_pane.inc: $description = t('Enter a valid email address for this order...);

Status: Needs review » Needs work

The last submitted patch, ubercart_checkout.patch, failed testing.

tr’s picture

tr commented
Status: Needs work » Closed (works as designed)

We don't need more than one issue open for this. You can contribute to #1257488: Make shipping quote pane description and error message really translatable if you want. But be aware that this is something that probably needs to be fixed in the i18n module, since it's i18n that doesn't properly work for variables defined outside a system_settings_form().

mgifford’s picture

mgifford
he/him
Primary language English
commented
Status: Closed (works as designed) » Closed (duplicate)

It doesn't work as designed, but thanks for a pointer to the right issue queue.