I've managed to get webforms up and running on Postgres. Following is a list of changes:

  • the install file didn't support PostgreSQL
  • wrong use of db_next_id() caused PostreSQL errors
  • double quotes (") can't be used for literal strings

db_next_id() seems to be a frequent cause of confusion, as most developers program for MySQL exclusively. The correct (ie. Postgres-compatible) format is db_next_id('{tablename}_columnname');. "columnname" should exactly match the column name the sequence is intended for.

Double quotes for literal strings seem to be not ANSI-compliant, so Postgres treats the string as identifier (table name). Switched on using single quotes instead.

Although all changes are for Postgres, i've added an update path for MySQL users to fix the sequence naming; they should run update.php after patching.

CommentFileSizeAuthor
webform_13.patch7.67 KBsmk-ka

Comments

Tobias Maier’s picture

if you have a little bit time it would be nice if you could remove

 TYPE=MyISAM

at the mysql part

and add the update path for the mysqls' utf8 support...
http://drupal.org/node/22218#utf8_sql
is not hard to do, just copy and paste...

thanks

ullgren’s picture

Assigned: Unassigned » ullgren
Status: Needs review » Fixed

Patch added to CVS and 4.7.0.

smk-ka’s picture

Seems like Pontus is too fast for me...
Anyway, the utf8 conversion was already part of the installer (FYI, it's update 3). I'll leave the MyISAM issue as it is (for now).

--
Stefan Kudwien
http://www.unleashedmind.com

ullgren’s picture

As far as I could tell the changes that Mr Maier asked for was allready in the patch. Or did I miss something ?

Tobias Maier’s picture

sorry i overlooked it

Anonymous’s picture

Status: Fixed » Closed (fixed)