After comment is submitted, this module says as follows;

"Assertion failed: "dropping more $form_state['submit_handlers'] than expected!". Please report this bug."

So I reported it.

Comments

arhak’s picture

Priority: Normal » Critical

I saw that one comming
it is a big deal
as it states: submission handlers of other comment-related modules are being dropped

but it would require a minor fix

arhak’s picture

Title: Error: "Assertion failed ... $form_state['submit_handlers'] » Assertion failed: dropping more submit handlers than expected
Status: Active » Postponed (maintainer needs more info)
StatusFileSize
new2.01 KB

I can't know what the situation is, since I have nothing to test on
could you please apply the attached patch?
it is intended to reveal which submit handlers are involved
by means of var_export them in two different times when a comment is saved (validation & actual submit)

afterwards, I will be able to make a decision on how to handle them

Takafumi’s picture

Status: Postponed (maintainer needs more info) » Active

I didn't got any output though I applied #2 patch.
So I added flush(), then I got output as follows;

array ( 0 => 'flatcomments_comment_form_submit', 1 => 'comment_form_submit', )
array ( 0 => 'flatcomments_comment_form_submit', 1 => 'comment_form_submit', )
arhak’s picture

>> So I added flush()
oh, sorry about that, it's nice to have wise people watching over

know thanks to you I have a quick answer: no problem with dropping the submit handlers because we are picking them up later
nevertheless, I'll debug it, to be sure

and now thanks to you I have flatcomments to test on

arhak’s picture

Category: bug » support
Priority: Critical » Minor
Status: Active » Fixed

checked
it introduces no bug, no misbehavior, just the annoying assertion

feel free to completely remove line 788 of comment_driven.module
that assertion was there to detect an unknown case
and now that we know it, we state we are ok with dropping every submit handler at that point

also committed to HEAD

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.