After comment is submitted, this module says as follows;
"Assertion failed: "dropping more $form_state['submit_handlers'] than expected!". Please report this bug."
So I reported it.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 2010-03-10_737982_TEMP_var_export_submit_handlers[unix].patch | 2.01 KB | arhak |
Comments
Comment #1
arhak commentedI saw that one comming
it is a big deal
as it states: submission handlers of other comment-related modules are being dropped
but it would require a minor fix
Comment #2
arhak commentedI can't know what the situation is, since I have nothing to test on
could you please apply the attached patch?
it is intended to reveal which submit handlers are involved
by means of var_export them in two different times when a comment is saved (validation & actual submit)
afterwards, I will be able to make a decision on how to handle them
Comment #3
Takafumi commentedI didn't got any output though I applied #2 patch.
So I added flush(), then I got output as follows;
Comment #4
arhak commented>> So I added flush()
oh, sorry about that, it's nice to have wise people watching over
know thanks to you I have a quick answer: no problem with dropping the submit handlers because we are picking them up later
nevertheless, I'll debug it, to be sure
and now thanks to you I have flatcomments to test on
Comment #5
arhak commentedchecked
it introduces no bug, no misbehavior, just the annoying assertion
feel free to completely remove line 788 of comment_driven.module
that assertion was there to detect an unknown case
and now that we know it, we state we are ok with dropping every submit handler at that point
also committed to HEAD