I often hit the delete button instead of the update button when trying to update a view's settings.

It would be nice if the delete button can be moved elsewhere, to the right maybe.

Thanks.

CommentFileSizeAuthor
#13 738792-disable-delete.patch1.04 KBdawehner
#11 garland.png12.21 KBdawehner
#10 updatedelete.jpg42.37 KBManyNancy

Comments

merlinofchaos’s picture

merlinofchaos commented

Do you have this problem on nodes as well? The placement is very similar (Save Cancel Delete on a view, Save Preview Delete on a node)

ManyNancy’s picture

ManyNancy commented

It's not the save and cancel button. It's the update button. When you click on a setting, such as a field or a filter or w/e a panel appears, and you can either update or cancel the setting.

merlinofchaos’s picture

merlinofchaos commented

Oh. Maybe the delete button needs to be greyed out the same way the save button is when the ajax form is open, then.

ManyNancy’s picture

ManyNancy commented

In my opinion the problem is the proximity, my theme already has the delete button greyed out. :)3

Thanks.

merlinofchaos’s picture

merlinofchaos commented

Well, by greyed out I mean disabled -- the 'Save' button cannot be clicked when you have the ajax form opened. So proximity won't matter. If you click the wrong button...nothing will happen.

ManyNancy’s picture

ManyNancy commented

That would be great, thank you!

esmerel’s picture

esmerel commented
Status: Active » Postponed
zualas’s picture

zualas commented

It would be good to remove the "Delete" button from view setup page and put it in the list of views. I accidentally deleted views many times while I just wanted to remove a display. The confirmation screen is of little help because most people stop reading them at some point. The Delete button is placed too close to other controls ...but maybe it's just me.

merlinofchaos’s picture

merlinofchaos commented
Status: Postponed » Closed (won't fix)

Typical Drupal workflow has a delete button next to save. If you're just clicking through the confirmation screen you're going too fast, since deleting a display does not have a confirmation screen, nor is the delete display button anywhere near the delete view button. Also, this button is nowhere near any of the widgets to control the current display, so I am not swayed by that argument in the slightest.

ManyNancy’s picture

ManyNancy commented
Status: Closed (won't fix) » Active
StatusFileSize
new updatedelete.jpg42.37 KB

Hi, since it's been a while since we've talked about this, I think you forgot what we were referring to. The problem isn't the save button, it's the update button.

These 2 buttons are really close together!

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new garland.png12.21 KB

this is a theme problem, see garland in the attachment

merlinofchaos’s picture

merlinofchaos commented

Ahh. In that case, the 'delete' button could be deactivated when the form is open, just like the 'save' button is. I actually thought it was but since the button isn't always there, we probably didn't think of it.

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new 738792-disable-delete.patch1.04 KB

Here is a patch for this

merlinofchaos’s picture

merlinofchaos commented
Version: 6.x-2.8 » 7.x-3.x-dev
Status: Needs review » Patch (to be ported)

Committed to 2.x and 3.x for D6. Doesn't apply to D7, needs porting.

dawehner’s picture

dawehner
Primary language German
commented
Status: Patch (to be ported) » Fixed

Works already how expected: It's not possible to click on the delete/revert link.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.