Hello, I added a new option for mobile xml sitemap generation according to google (http://www.google.com/support/webmasters/bin/answer.py?hl=en&answer=34648)

CommentFileSizeAuthor
#12 xmlsitemap_new_2.patch2.71 KBsunwarior
#10 xmlsitemap_new_2.patch2.71 KBsunwarior
#8 xml_sitemap_new.patch2.82 KBsunwarior
#6 xmlsitemap_mobile.patch3.06 KBsunwarior
#2 xmlsitemap_mobile.patch3.06 KBsunwarior
0001-mobile.patch3.66 KBsunwarior

Comments

Status: Needs review » Needs work

The last submitted patch, 0001-mobile.patch, failed testing.

sunwarior’s picture

sunwarior commented
StatusFileSize
new xmlsitemap_mobile.patch3.06 KB
sunwarior’s picture

sunwarior commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, xmlsitemap_mobile.patch, failed testing.

Anonymous’s picture

Anonymous (not verified) commented

You added an empty line to pages.inc causing an unintended hunk at line 96.
The testbot needs the difference from CVS.

sunwarior’s picture

sunwarior commented
Status: Needs work » Needs review
StatusFileSize
new xmlsitemap_mobile.patch3.06 KB

Status: Needs review » Needs work

The last submitted patch, xmlsitemap_mobile.patch, failed testing.

sunwarior’s picture

sunwarior commented
Status: Needs work » Needs review
StatusFileSize
new xml_sitemap_new.patch2.82 KB

Status: Needs review » Needs work

The last submitted patch, xml_sitemap_new.patch, failed testing.

sunwarior’s picture

sunwarior commented
Component: Other » Code
Status: Needs work » Needs review
StatusFileSize
new xmlsitemap_new_2.patch2.71 KB
Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Needs work

You've misspelled or mistyped the word display in the #description value in the first hunk. You've not correctly indented the action of the if statement in the last change, I suspect a tab vs spaces issue.

+  $form['general']['xmlsitemap_mobile'] = array(
+    '#type' => 'checkbox',
+    '#title' => t('Display as mobile sitemap'),
+    '#default_value' => variable_get('xmlsitemap_mobile', 0),
+    '#description' => t('Dispaly sitemap in mobile format'),
+  );

+      if ($is_mobile) {
+      	$link->output .= "\t<mobile:mobile/>\n";
+      }
sunwarior’s picture

sunwarior commented
Status: Needs work » Needs review
StatusFileSize
new xmlsitemap_new_2.patch2.71 KB
Anonymous’s picture

Anonymous (not verified) commented
Version: 6.x-1.2 » 6.x-2.x-dev

I just noticed that your feature patch was against 6.x-1.2 which is feature frozen. We'll have to see what the bot does with 2.x-dev.

Anonymous’s picture

Anonymous (not verified) commented

#12: xmlsitemap_new_2.patch queued for re-testing.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Needs work

This also needs to wait until after the context API & UI lands. Otherwise rolling the patch now is not going to work. This will also need tests written to make sure it works and stays working.

I'm half-tempted to mark this postponed, but I'll just let you know when its time.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Version: 6.x-2.x-dev » 7.x-2.x-dev
Status: Needs work » Postponed
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

In order for this to land, #764658: Use XMLWriter class instead of fwrite() needs some review.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Postponed » Closed (duplicate)

Merging this request into #451234: Support for extended sitemap formats (e.g. video, news, image, mobile).