Make table field ready for 4.7

Losik - July 16, 2006 - 11:32
Project:Flexinode
Version:4.7.x-1.x-dev
Component:Field type: contributions
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs work
Description

Very serious bug in table component: when you have several tables in one page, Drupal/Flexiblock will be show only one (I think, last). Reason (AFAIK):

$form['table'][... (line 22 in field_table.inc),

after

foreach($items as $key => $item) {
$form[$key] = $item;
}
(line about 580 in flexinode.module)

we have only one array with name 'table'.

I was changed this line in field_table.inc like this:

$form[$fieldname][$fieldname.'_rows'] = array( //заменим table на $fieldname...

and many other items from 'table' to $fieldname, it seems a slolution.

P. S. Sorry for bad English, it is my non-native language ;-)

#1

Bèr Kessels - July 16, 2006 - 21:21
Category:bug report» support request

I do not understand your problem?. So I am making this a support request, untill we know what the prolem is.

* Are you using any non-released field .inc files?
* Did you follow the install instructions? Are you seeing problesm with non-existing database tables? Is that the problem?
* What page can we see the bug?
* What do we need to do to reproduce it?

#2

Losik - July 17, 2006 - 10:01

>I do not understand your problem?
Hmmm... The problem: if you have 3 flexinode tables in one Web page you will see only one.

>* Are you using any non-released field .inc files?
No, the problem in contribution file, included in distributive (http://ftp.osuosl.org/pub/drupal/files/projects/flexinode-4.7.0.tar.gz)

>* Did you follow the install instructions? Are you seeing problesm with non-existing database tables? Is that the problem?
Yes, I follow all install instructions. Database tables is exist ;-)

>* What page can we see the bug?
Any page with Flexinode Table widget.

>What do we need to do to reproduce it?
1. Create Flexinode Content Type with name Test Table.
2. Add 3 tables (Table 1, Table 2, Table 3)
3. Create Content, Test Table.
4. See the page 8)

#3

Losik - July 17, 2006 - 10:03

Addition: I test it on clean Drupal install, with last released version Flexinode.

#4

Bèr Kessels - July 17, 2006 - 13:25
Title:Very serious bug in table component» Make table field ready for 4.7
Priority:critical» normal

Table field was not ready for 4.7. Whe are repairing the broken fields one at the time.

I am removing this for now.

#5

Losik - July 17, 2006 - 16:26

Thanks.

P. S. Solution, which described in my first post in this thread seems is fully working.

#6

Bèr Kessels - January 2, 2007 - 10:22
Category:support request» bug report
Status:active» needs work

Not a suppoort req. but a feature request: update table field inc to 4.7

However, we need a real patch: http://drupal.org/diffandpatch

 
 

Drupal is a registered trademark of Dries Buytaert.