Hi,

Thanks for the modules. I tried them out today but found a few things. 1. no node_recommendation_views.inc file, 2. install didn't work, 3. (i installed db manually) warning: Invalid argument supplied for foreach() in /home/site/public_html/modules/cre/node_recommedation.module on line 171, and

Question: why are there two modules with the same name?

I didn't look at the code much.

Good luck.

Comments

Scott Reynolds’s picture

Scott Reynolds commented

I need a bit more information. What database you using PGSQL or MySQL? What was node_recommendation.module trying to display? Block or page?

Any message when it was installing?

node_recommendation_views.inc is coming... meant to take that out of the release. Views integration not quite ready.

Scott Reynolds’s picture

Scott Reynolds commented

modules with same name? You mean cre.install and cre.module?

jwilde’s picture

jwilde commented

Hi Scott,

I'm using mysql and drupal 4.7.2. I didn't see any install information.

I removed the check for views so I could continue testing.

In the main cre directory there is node_recommedation.module and in the recommendation-modules directory there is the same named module but a different size.

I think I was trying to enable a block.

Jim

Scott Reynolds’s picture

Scott Reynolds commented

This is not making much sense. I have tested the download link on drupal and i have only gotten one node_recommendation.module. And that does not have an .install file.

This makes me think your download was corrupt. But I am goin to add a check to make sure votingapi is install on the system (realized I didnt do that). And when the module is installed you should recieve a CRE table created message.

I have done a clean install a live server and recieved no such error. Running mysql 5 and 4.7.2

jwilde’s picture

jwilde commented

Hi Scott,

The download looks good. Install msg displayed ok. BTW I removed the check for views.

I using it on a system with limited posts but it displays the rated ones ok. But, cre displays them in a funky sequence. For example, on the node rec page, it displays three posts as:

- blank
- post
- post
- blank
- post
- blank

It lists the bullet but no posts. I'll continue to play around with it and get back to you. Thanks for the module.

Jim

Scott Reynolds’s picture

Scott Reynolds commented

This is what i think has happened. I have tested everything i can think of and I think i have found the situtation. Votingapi does NOT handle nodeapi hooks. So for instance, if someone voted on a node and that node was later removed from the node table via node_delete the vote would still exist. And then the cre engine is installed on top of the voting data (which still holds the non-existent node votes) and it recommends that node, even though it doesn't exist.

So, I am adding a check in node_recommendation.module to make sure the node exists. If it doesn't i am goin to have it create an error message to tell the admin that he/she needs to remove some vote objects that exists for a given node. And it will fix the cre table

Please, check to see if this is whats happening to you.

jwilde’s picture

jwilde commented

Hey Scott,

Looking at the voting tables, there are some that have values from nodes that were removed. The check is a good idea.

Jim

Scott Reynolds’s picture

Scott Reynolds commented

Ok created a hot fix for this where a watchdog message will be displayed with the offending nid that exists in both the votingapi_vote table and the cre_similarity_matrix. Using the new verision you can manually remove all references to this offending nid by running this in mysql:

DELETE from cre_similarity_matrix WHERE content_id1 = 456 OR content_id2 = 456;

This will prevent cre from recommending node 456 ever again...because that node no longer exists...

More permant fix is coming, but this should help in the mean time

Scott Reynolds’s picture

Scott Reynolds commented
Status: Active » Closed (fixed)

Ok closing this issue. New release will not suffer from this affliction because of the new query object.

jwilde’s picture

jwilde commented

Thank you Scott. I appreciate your time and efforts. "'ll keep you up to date on any further developments.

Jim