In parent.js where the iframe is created, if we add to the IE conditional to also set frameborder="0" this would remove the border that shows around all iframes in IE, while no border shows by default in other browsers.

This would improve the cross browser consistency of this module.

CommentFileSizeAuthor
#5 modalframe.patch844 bytescorey.aufang
#2 frameborder.png7 KBcorey.aufang

Comments

markus_petrux’s picture

markus_petrux commented
Status: Active » Postponed (maintainer needs more info)

I think the CSS class #modalframe-element covers this issue. Please, see modalframe.parent.css

Maybe I missed the difference when testing with IE6 to IE8? Could you please attach a screenshot where we can see the effect of not using frameborder="0" for IE?

corey.aufang’s picture

corey.aufang commented
StatusFileSize
new frameborder.png7 KB

Here is a screen shot, on the left is without frameborder="0" and on the right is with. This is in IE8.

corey.aufang’s picture

corey.aufang commented
Status: Postponed (maintainer needs more info) » Needs review

forgot to change status

corey.aufang’s picture

corey.aufang commented
Title: Remove frameborder in IE » Internet Explorer issues with IFRAME

I also found another discrepancy in how the IFRAME is displayed in IE.

In browsers other than IE you can set the background of the iframe to transparent and it will show what ever is behind the iframe.

By default, IE does not allow this unless you put an additional argument of allowtransparency="true" into the IFRAME tag.

corey.aufang’s picture

corey.aufang commented
StatusFileSize
new modalframe.patch844 bytes

Here is a patch with the suggested changes.

Also of note that these are defaults in Drupal 7's overlay module.

markus_petrux’s picture

markus_petrux commented
Status: Needs review » Fixed

Committed to CVS. Thanks (and sorry for the delay)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.